swift attaching file to both letters

Question

I`m sending two letters by Swift:

$mail = Mailer::getInstance($oData->Subject);
                    $mail->setTo($oData->Email, $oData->Recipient)
                        ->setBody($body , 'text/html')
                        ->setFrom(array('some@gmail.com' => 'some.com'));
                    $mail->setAttach($_FILES["Resume"]["tmp_name"]);

                    if (isset($aContent['Recipient']) && !empty($aContent['Recipient']['Value'])) {
                        $mail->setTo($aContent['Recipient']['Value']);
                    }

                    if ($mail->send()) {
                        $mail2 = Mailer::getInstance("Thanks!");
                        $mail2->setFrom(array('some@gmail.com' => 'some.com'))
                            ->setTo(array($aContent['Email']['Value']))
                            ->setBody($thanksEnding , 'text/html')
                            ->setSubject("Wonderful Subj");
                        if ($mail2->send()) {
                            $this->show->success = TRUE;
                            $this->show->message = __("Message sent.");
                        }
                    } else {
                        $this->show->message = __("Error.");
                    }

and both of letters have attachments. How can I make attachment to first letter only?

Show the code of `Mailer::getInstance`! Most probably that is causing your trouble. — Levente Pánczél, Mar 03 '14 at 13:08
I solved a problem using code $mail2 = new Mailer("Thanks!"); — user3374941, Mar 03 '14 at 14:05

score 1 · Accepted Answer · answered Mar 03 '14 at 13:02

1

getInstance()

Looks like either factory or singleton pattern. It looks more like a singleton pattern and therefore you'll get the SAME instance of the object when calling.

So $mail and $mail2 are probably the same instances.

Use better design patterns and make fresh instances using new Mailer().

answered Mar 03 '14 at 13:02

Daniel W.

31,164
13
93
151

Thanks, I think it will help. – user3374941 Mar 03 '14 at 13:30

score 0 · Answer 2 · answered Mar 03 '14 at 12:58

0

calling $mailer2->setAttach(null); before sending it may do the trick.

answered Mar 03 '14 at 12:58

Loïc

11,804
1
31
49

Excuse me, not fatal error, just warning, but message anyway was not sent – user3374941 Mar 03 '14 at 13:04
Warning: fopen() [function.fopen]: Filename cannot be empty in ... Warning: Cannot modify header information - headers already sent by (output started at ... – user3374941 Mar 03 '14 at 13:05
`$mailer2->removeAttach()` ? What methods do you have on the mailer objects?? – Daniel W. Mar 03 '14 at 13:19

swift attaching file to both letters

2 Answers2