What is wrong with my UIAlertView delegate method?

Question

I'm pretty new to Objective-C so hopefully this all makes sense. Here after authentication of user name and password fields the UIAlertView pops up. What I want is when the user presses the UIAlertViewButton. The Control should navigate to instruction view controller.

But here it is not working

Here is .h file code:

#import <UIKit/UIKit.h>
#import "InstructionBIDViewController.h"
@interface SignInViewController : UIViewController<UIAlertViewDelegate>{

    IBOutlet UITextField *usernamefield;
    IBOutlet UITextField *password;
    NSDictionary *creditialDictionary;
}
@property (strong, nonatomic) InstructionBIDViewController *viewControllerinst;
-(IBAction)enterCredential;
//-(void) submitData;
@end

Here is .m file code:

#import "SignInViewController.h"
#import "InstructionBIDViewController.h"
@interface SignInViewController ()

@end

@implementation SignInViewController
@synthesize viewControllerinst;
- (id)initWithNibName:(NSString *)nibNameOrNil bundle:(NSBundle *)nibBundleOrNil
{
    self = [super initWithNibName:nibNameOrNil bundle:nibBundleOrNil];
    if (self) {

    }
    return self;
}

- (void)viewDidLoad
{
    [super viewDidLoad];
        //[self submitData];
    creditialDictionary = 
      [[NSDictionary alloc ] initWithObjects:
        [NSArray arrayWithObjects:@"password",@"1234",nil] 
                                     forKeys:
        [NSArray arrayWithObjects:@"username", @"alex",nil]];

}
-(IBAction)enterCredential
{
    if ([[creditialDictionary objectForKey:usernamefield.text] 
           isEqualToString:password.text]) {
        UIAlertView *alert = 
          [[UIAlertView alloc] initWithTitle:@"Correct Password" 
                                     message:@"This password is correct" 
                                    delegate:self 
                           cancelButtonTitle:@"Dismiss"  
                           otherButtonTitles:nil];
        [alert show];
    } else {
        UIAlertView *alert = 
          [[UIAlertView alloc] initWithTitle:@"InCorrect Password" 
                                     message:@"This password is incorrect" 
                                    delegate:self 
                           cancelButtonTitle:@"Dismiss" 
                           otherButtonTitles:nil];
        [alert show];
    }
}

//-(void) alertView:(UIAlertView *)alertView 
          clickedButtonAtIndex:(NSInteger)buttonIndex{
//Here the functionality that i want to perform ...but it is not working
    - (void)alertView:(UIAlertView *)alertView 
            didDismissWithButtonIndex:(NSInteger)buttonIndex{
    // u need to change 0 to other value(,1,2,3) if u have more buttons.
    // then u can check which button was pressed.

    if (buttonIndex == alertView.cancelButtonIndex) {
        // Cancelled
        viewControllerinst = [[InstructionBIDViewController alloc]
          initWithNibName:@"InstructionBIDViewController" bundle:nil];
        [self.navigationController pushViewController:viewControllerinst 
                                             animated:YES];
    }   
}

@end

Please help me to perform this navigation using UIAlertView ?

I bet the problem is that his delegate method should be looking for a different buttonIndex and not the cancelButtonIndex. — Michael Dautermann, Feb 28 '14 at 09:06
On pressing alertview buttonO(cancelButtonTitle:@"Dismiss") the control is not shifting to InstructionBIDViewController .... — user3239274, Feb 28 '14 at 09:07
Insert a breakpoint inside the the if statement and verify if it's called. — bsarr007, Feb 28 '14 at 09:08
Code is correctly debugging this line : [self.navigationController pushViewController:viewControllerinst animated:YES]; ....but it reaching in viewDidLoad InstructionBIDViewController ... — user3239274, Feb 28 '14 at 09:11
@user3239274 you get code so please upvote my answer and please tick right please . thanks advanced. — Darshan Kunjadiya, Feb 28 '14 at 10:13
the program is crashing at viewDidLoad of InstructionBIDViewController.h why ? — user3239274, Feb 28 '14 at 10:28

score 0 · Answer 1 · answered Feb 28 '14 at 09:07

0

It looks ok at a first glance to me.

If its running but not pushing anything my wild guess would be you might not actually be in a navigation controller, so self.navigationController is nil.

answered Feb 28 '14 at 09:07

Daniel Broad

2,512
18
14

Darshan Kunjadiya · Accepted Answer · 2014-02-28T10:11:09.050

Try this method for get event of alert button

Change you appdelegate this method :

    - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
    self.window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]];


    viewController=[[SignInViewController alloc] init];

    UINavigationController *navigationcontroller=[[UINavigationController alloc] initWithRootViewController:viewController];
    [self.window setRootViewController:navigationcontroller];

    //self.window.rootViewController = self.viewController;
    self.window.backgroundColor = [UIColor whiteColor];
    [self.window makeKeyAndVisible];
    return YES;
}

// add this in your signinviewcontroller.

    -(void)alertView:(UIAlertView *)alertView clickedButtonAtIndex:(NSInteger)buttonIndex
{

        if (buttonIndex == 0 )
        {
              viewControllerinst = [[InstructionBIDViewController alloc] initWithNibName:@"InstructionBIDViewController" bundle:nil];
             [self.navigationController pushViewController:viewControllerinst animated:YES];
        }

}

i hope this code useful for you.

the program is crashing at viewDidLoad of InstructionBIDViewController.h why ?please help... — user3239274, Feb 28 '14 at 10:34
@user3239274 you download my code ? in my mac this code will perfectly working now. — Darshan Kunjadiya, Feb 28 '14 at 10:38
@user3239274 only change your code appdelegate method and alertview method. — Darshan Kunjadiya, Feb 28 '14 at 10:40

score 0 · Answer 3 · answered Feb 28 '14 at 09:54

You don´t need delegate method for your incorrect password so when you create your alert you don´t need you set delegate to self.

This code should work

if ([[creditialDictionary objectForKey:usernamefield.text]isEqualToString:password.text]) {
    UIAlertView *alertForCorrect = [[UIAlertView alloc  ]initWithTitle:@"Correct Password" message:@"This password is correct" delegate:self cancelButtonTitle:@"Dismiss"  otherButtonTitles:nil];
    [alertForCorrect show];
}
else{
    UIAlertView * alertForIncorrect=[[UIAlertView alloc  ]initWithTitle:@"InCorrect Password" message:@"This password is incorrect" delegate:nil cancelButtonTitle:@"Dismiss" otherButtonTitles:nil];
    [alertForIncorrect show];
}

So your alertForCorrect will be the only one you will receive in your delegate method alertView:clickedButtonAtIndex:

So implement your method like this:

- (void)alertView:(UIAlertView *)alertView didDismissWithButtonIndex:(NSInteger)buttonIndex {
    if (buttonIndex == 0) {
        // Cancelled
        viewControllerinst = [[InstructionBIDViewController alloc] initWithNibName:@"InstructionBIDViewController" bundle:nil];
        [self.navigationController pushViewController:viewControllerinst animated:YES];
    }
}

What is wrong with my UIAlertView delegate method?

Here is .h file code:

Here is .m file code:

3 Answers3