Listview - onClickListener's onClick called on reused view

Question

I have list view and every row has multiple clickable areas. In bindView(I use CursorAdapter) I set onClickListener for every clickable area and everything works fine.

Problem occurs when I click on view and at the same time notifyDataSetChanged is called (or cursor is changed)

It seems that when I click first item, but before OnClickListener is called, view is reused(bindView is called) for second item and onClickListener is called on second item. My only idea is that view is reused after touch is fired but before onClickListener is called. Any idea how to fix it or what can be wrong?

EDIT: If clicked view is inside scrollable there is 180ms delay between onTouch and onClick to find out whether it's click or scroll. So if view is reused between onTouch and onClick, onClick is called on reused (wrong) row.

Almost same can be more easily reproduces with OnLongClickListener.

@Override
  public void bindView(View view, Context context, Cursor cursor) {
         View clickableView = view.findViewById(R.id.clickable_view);
         clickableView.setOnClickListener(new View.OnClickListener() {
             public void onClick(View v) {
                 final int position = getListView().getPositionForView(v);
                 if (position != ListView.INVALID_POSITION) {
                      //it display position 2 even when I clicked at position 1
                     Toast.makeText(getContext(), "Position " + position, Toast.LENGTH_SHORT).show();
                 }
         });
  }

score 0 · Answer 1 · answered Feb 19 '14 at 20:50

You probably want to make your onClickListener private.

    public View newView(Context context, Cursor cursor, ViewGroup parent) {
    ViewHolder holder = new ViewHolder();
    View view = inflater.inflate(R.layout.yourrow, parent, false);


    holder.your_textview = (TextView) view.findViewById(R.id.tv_your_textviewfield);
    holder.your_textview.setOnClickListener(mMoves_OnClickListener);
    holder.position = cursor.getPosition();
    bindView(view, context, cursor);
    view.setTag(holder);
    return view;
}

private OnClickListener mMoves_OnClickListener = new OnClickListener() {
    public void onClick(View v) {

        ViewHolder holder = (ViewHolder) ((View) v.getParent()).getTag();

        switch (v.getId()) {
        case R.id.tv_your_textviewfield:
            ((OnMoveScoreSelectedListener) context).onMoveScoreClickSelected();
            break;
        case ...
        }
    }
};

Thanks, but this doesn't help – Martin Vandzura Feb 20 '14 at 06:23 — Martin Vandzura, Feb 20 '14 at 06:23

Listview - onClickListener's onClick called on reused view

1 Answers1