Program Wont Work As Expected

Question

I have an issue here. I have to make a program that checks if a credit card number is valid or not using the checksum. I'm supposed to multiply every other digit starting from the second to last digit, then add the products then add the numbers that weren't multiplied to that sum as well. The result should produce 0 when divided. However, Im having an issue here with my program. When I enter large numbers, the values change up and at the end I get Floating point exception(core dumped). When I enter smaller numbers, sometimes it works, sometimes it doesn't. Please help me out.

Thank you for your help. Please explain the issue so I can avoid it later.

One of your mathematical calculations is producing a number that's too large or too small to fit into the data type you have chosen. Find out why. — Robert Harvey, Feb 07 '14 at 00:23
says 'Floating point exception' but I dont see any floating point stuff — pm100, Feb 07 '14 at 00:27
@pm100 Does not matter. Integer division by zero can do this, for example. — tommyo, Feb 07 '14 at 00:32

score 3 · Accepted Answer · edited Aug 31 '16 at 21:32

3

I think you may have a problem when iterating i up to a large cardNum because cardNum is long long which can hold huge numbers but int i is just an int relatively small.

To solve this problem try holding the cardNum as a string extracting each digit from it and parsing them into an int. You can then multiply and add them up without dealing with representing huge numbers.

edited Aug 31 '16 at 21:32

Anfernee

1,445
1
15
26

answered Feb 07 '14 at 00:25

clancer

613
4
10

Yes, this was the issue. Thank you. – Anfernee Feb 07 '14 at 01:56

score 0 · Answer 2 · answered Feb 07 '14 at 00:28

0

cardnum needs to be a string not a number, you are looping over it expecting to get each digit. YOur for loop will give you all the number from 1 to the credit card number (a long loop)

answered Feb 07 '14 at 00:28

pm100

48,078
23
82
145

Program Wont Work As Expected

2 Answers2