Perl script: validity of a directory always return false

Question

I want to read some parameters from a file using perl script. I used grep command to find the values of thoses parameters.

#!/usr/bin/perl

if( scalar @ARGV ==0)
{
  die "Number of argument is zero. Please use: perl <script_name> <cdc68.ini> \n";
}


if( !-f $ARGV[0])     ## if the 1st arg is not a file
{
   die "$ARGV[0] is not a valid file type \nInput Arguments not correct!!! \n";
}

my $file_cnf=$ARGV[0];

my $DEST_PATH=`grep relogin_logs $file_cnf | cut -d "=" -f2`;

my $SRC_PATH=`grep dump_logs $file_cnf | cut -d "=" -f2`;
my $FINAL_LOG=`grep final_log $file_cnf | cut -d "=" -f2`;

print "\n$DEST_PATH \n $SRC_PATH \n $FINAL_LOG\n";


if ( !-d $DEST_PATH)
{
  die "$DEST_PATH is not a dir";
}

else
{
  print "ok";
}

the file I want to read is

cat cdc68.ini
reconn_interval=15
relogin_logs=/osp/local/home/linus/pravej/perlD/temp/relogin/
dump_logs=/osp/local/home/linus/pravej/perlD/temp/
final_log=/osp/local/home/linus/pravej/perlD/final_log/
Number_days=11

Sample output:

perl readconfig.pl cdc68.ini
/osp/local/home/linus/pravej/perlD/temp/relogin/
/osp/local/home/linus/pravej/perlD/temp/
/osp/local/home/linus/pravej/perlD/temp/relogin/
is not a dir at readconfig.pl line 26.

Can anyone suggest what I'm doing wrong here? Please note that I dont want to use any perl module like config or tiny.pm. Also these dir already exist in my unix system Thanks in advance for your help

Who don't you want to use an established module that parses INI-like config files? Is this homework? — Dan Dascalescu, Feb 04 '14 at 09:33
These modules are not included in our sunOs platform and sir rest assure it is not a homework. on Linux platfrom I used the Config module and that works fine. Problem is with the sunOs that didnt has these module so I try grep. Hope you understand. — Pravej Khan, Feb 04 '14 at 09:37

mpapec · Answer 1 · 2014-02-04T09:45:51.800

5

You can use perl parsing instead of shell utils

my $file_cnf = $ARGV[0];

open my $fh, "<", $file_cnf or die $!;
my %ini = map /(.+?)=(.+)/, <$fh>;
close $fh;

print "\n$ini{relogin_logs} \n $ini{dump_logs} \n $ini{final_log}\n";

edited Feb 04 '14 at 09:45

answered Feb 04 '14 at 09:39

mpapec

50,217
8
67
127

Dear sir, I can't use any perl module. – Pravej Khan Feb 04 '14 at 09:45
4

@PravejKhan and there is none in example above. – mpapec Feb 04 '14 at 09:47

score 3 · Accepted Answer · answered Feb 04 '14 at 10:09

mpapec's alternative parsing is much better than your current script. But, for what it's worth, your original problem is that the result of the backtick operator includes the newline character at the end of the string.

You can remove it with chomp, eg:

my $DEST_PATH=`grep relogin_logs $file_cnf | cut -d "=" -f2`;
chomp $DESTDIR;

Do this with the result of all your backtick commands.

Perl script: validity of a directory always return false

2 Answers2