TypeError: insert() takes at least 2 arguments (1 given) mongoDB

Question

sorry if this is dumb question, but this is the first time i've used python and Mongo DB. Anyway, the problem I have is that I am trying to insert() a string to be stored in my data base -by read()-ing data in with a loop and then giving insert() line 1 and line2 in a single string (This is probably a messy way of doing it but I don't know to make read() read 2 lines at a time.)- but I get this error when running it: TypeError: insert() takes at least 2 arguments (1 given)

from pymongo import MongoClient

client = MongoClient("192.168.1.82", 27017)
db = client.local
collection = db.JsonDat

file_object = open('a.txt', 'r')

post=collection.insert()

readingData = True
def readData():
    while readingData==True:
        line1 = file_object.readline()
        line2 = file_object.readline()

        line1
        line2

        if line1 or line2 == "":
            readingData = False

        dbData = line1 %line2
        post(dbData)
    print collection.find()

`post=collection.insert()` what do you wants to insert into collection ? — Grijesh Chauhan, Feb 02 '14 at 09:09

Cairnarvon · Answer 1 · 2014-02-02T09:29:03.463

4

The relevant part of your code is this:

post=collection.insert()

What you're doing there is calling the insert method without arguments rather than assigning that method to post. As the insert method takes as its arguments at least the document you're trying to insert and you haven't passed it anything, it only receives (implicitly) the object itself; that is, one argument instead of the at-least-two it expects.

Removing the parentheses ought to work.

edited Feb 02 '14 at 09:29

answered Feb 02 '14 at 09:10

Cairnarvon

25,981
9
51
65

Apparently, @user3196428 is trying to assign the _function_ itself to `post`, so they actually mean `post=collection.insert`, without a call to `insert` – lanzz Feb 02 '14 at 09:23
Good answer. I put in an edit to clarify a bit though. Also had to make mention of the whole **local** database thing shown in the code. – Neil Lunn Feb 02 '14 at 09:23
@Cairnarvon Edit to say you can't do that. Assignment is not a way to make a reference to a method. Just do `collection.insert({ .. }) in the place where it's needed – Neil Lunn Feb 02 '14 at 09:26
@lanzz Oh, you seem to be right. I've adjusted my answer accordingly. – Cairnarvon Feb 02 '14 at 09:31
@NeilLunn I don't see why assignment wouldn't work as expected. Can you elaborate? – Cairnarvon Feb 02 '14 at 09:32
Added the elaboration to the answer given. Not the correct use of a closure. – Neil Lunn Feb 02 '14 at 09:37

score 1 · Answer 2 · edited May 23 '17 at 12:21

It appears as has been pointing out that you are attempting to create a closure on the insert method. In this case I don't see the point as it will never be passed anywhere and/or need to reference something in the scope outside of where it was used. Just to the insert with arguments in the place where you actually want to use it, ie where you are calling post with arguments.

Happy to vote up the answer already received as correct. But really want to point out here that you appear to be accessing the local database. It is likely found this by inspecting your new mongo installation and saw this in the databases list.

MongoDB creates databases and collections automatically as you reference them and commit your first insert.

I cannot emphasize enough DO NOT USE THE LOCAL DATABASE. It is for internal use only and will only result in you posting more issues here from the resulting problems.

TypeError: insert() takes at least 2 arguments (1 given) mongoDB

2 Answers2