Objective-C exercises undeclared identifier error

Question

I'm currently teaching myself Objective-C as a first language. I understand the difficulty involved, but I'm quiet a persevering individual. I've began to do the exercises on the Apple Objective-C documentation. My goal is to have my program log out my first and last name instead of a generic Hello World greeting.

I keep receiving a Use of Undeclared identifier error. I'm trying to figure out what is causing the error.

Here is the introClass.h

    #import <UIKit/UIKit.h>

    @interface XYZperson : NSObject

    @property NSString *firstName;
    @property NSString *lastName;
    @property NSDate *dateOfBirth;
    - (void)sayHello;
    - (void)saySomething:(NSString *)greeting;
    + (instancetype)person;
    -(int)xYZPointer;
    -(NSString *)fullName;
    @end

Here is IntroClass.m

#import "IntroClass.h"

@implementation XYZperson
-(NSString *)fullName
{
    return[NSString stringWithFormat:@" %@ %@", self.firstName, self.lastName];
}

-(void)sayHello
{
    [self saySomething:@"Hello %@", fullName]; //use of undeclared identifier "fullName"
};

-(void)saySomething:(NSString *)greeting
{
    NSLog(@"%@", greeting);
}

+(instancetype)person{
   return [[self alloc] init];
};

- (int)xYZPointer {
    int someInteger;
    if (someInteger != nil){
        NSLog(@"its alive");
    }
    return someInteger;
};


@end

Sergey Kalinichenko · Accepted Answer · 2014-01-29T20:27:25.663

2

The problem is that fullName is the name of a method. It should be invoked on self with square brackets.

Since saySomething: expects a single parameter, you need to either (1) remove the @"Hello %@" portion of the call, like this:

-(void)sayHello {
    [self saySomething:[self fullName]];
};

or to make a single string from @"Hello %@" and [self fullName], like this:

-(void)sayHello {
    [self saySomething:[NSString stringWithFormat:@"Hello %@", [self fullName]]];
};

edited Jan 29 '14 at 20:27

answered Jan 29 '14 at 20:00

Sergey Kalinichenko

714,442
84
1,110
1,523

This returns an error: Too many arguments to method call, expected 1, have 2. – TheM00s3 Jan 29 '14 at 20:24
Thank you so much, it worked! Could you also explain as to why is SayHello method only allowing for 1 argument? – TheM00s3 Jan 29 '14 at 20:52
@user3084800 That's because it is declared that way: in order to allow for multiple arguments, functions need to either declare "named" arguments, as in `-(void)saySomething:(NSString *)greeting toSomeone:(NSString*)target;` or allow a variable number of arguments, as in `stringWithFormat:` call. – Sergey Kalinichenko Jan 29 '14 at 20:59

Sam B · Answer 2 · 2014-01-29T20:51:32.367

You are passing back a string of first and last name but I don't see anywhere that you had set a value for them. As others noted try

    -(void)sayHello
    {
         _firstName = [NSString stringWithFormat:@"John"];
         _lastName = [NSString stringWithFormat:@"Doe"];

         //if you want to see what's happening through out your code, NSLog it like
        NSLog(@"_firstName: %@ ...", _firstName);
        NSLog(@"_lastName: %@ ...", _lastName);

        NSString *strReturned = [self fullName];
        NSString *concatStr = [NSString stringWithFormat:@"Hello %@", strReturned];

        NSLog(@"strReturned: %@ ...", strReturned);
        NSLog(@"concatStr: %@ ...", concatStr);

        [self saySomething:concatStr]; 
    };

    -(NSString *)fullName
    {
        return[NSString stringWithFormat:@" %@ %@", self.firstName, self.lastName];
    }

I tried the second way and it auto corrected the firstName to _firstName and lastName to _lastName. I get an error on the [self saysomething:@"hello %@", [self fullname]]; that states: Too many arguments to method call, expected 1, have 2. — TheM00s3, Jan 29 '14 at 20:26

score 0 · Answer 3 · answered Jan 29 '14 at 20:07

0

use

[self saySomething:@"Hello %@", self.fullName]];

or

[self saySomething:@"Hello %@", [self fullName]];

answered Jan 29 '14 at 20:07

santhu

4,796
1
21
29

Objective-C exercises undeclared identifier error

3 Answers3