Begin, Rescue with API endpoint

Question

Here is my method:

def get_video_duration
  @time ||= Panda.get("/videos/#{@video.panda_id}/metadata.json")["duration"]
  format_duration
end

I need to write this method "better" in wrapping it with a begin, rescue block so that @time could be nil depending on the response from the API.

Do you want to execute `Panda.get` always, or only when `@time` is nil/false? — the Tin Man, Jan 27 '14 at 15:45

score 2 · Accepted Answer · edited Jan 27 '14 at 15:49

2

Yes, possible using inline rescue clause.

def get_video_duration
    @time ||= Panda.get("/videos/#{@video.panda_id}/metadata.json")["duration"] rescue nil
    format_duration
end

Or better explicitly do it.

def get_video_duration
  @time ||= Panda.get("/videos/#{@video.panda_id}/metadata.json")["duration"]
rescue YourException
  @time = nil
  format_duration
end

edited Jan 27 '14 at 15:49

Roman Kiselenko

43,210
9
91
103

answered Jan 27 '14 at 14:39

Arup Rakshit

116,827
30
260
317

You ruin the logic of the OP. In the original question there was lazy instantiation of `@time` while you set it in any case despite whether is was already set or not. – Aleksei Matiushkin Jan 27 '14 at 14:49
@mudasobwa If that's what OP meant, I will delete this. Lets wait OP to come back and respond, this is not what (s)he wanted. – Arup Rakshit Jan 27 '14 at 14:57
@ArupRakshit - Thanks for the help! The lazy instantiation of `@time` is what I was going for – dennismonsewicz Jan 27 '14 at 15:44
@dennismonsewicz Is this solved your problem...? Now – Arup Rakshit Jan 27 '14 at 15:45

score 1 · Answer 2 · answered Jan 27 '14 at 14:48

1

Maybe break it down with an additional method :

def fetch_video_duration

  Panda.get("/videos/#{@video.panda_id}/metadata.json")["duration"]

  rescue
    return nil
end

def get_video_duration
  @time ||= fetch_video_duration

  format_duration
end

answered Jan 27 '14 at 14:48

SciPhi

2,585
1
18
19

Begin, Rescue with API endpoint

2 Answers2