22

I forked another person's repository, made some of my own commits, and then sent a pull request back to the user. The user has not been active lately, and I do not see myself contributing any more to the project.

I would still like to see my pull request accepted and merged in one day, but I do not want to keep my version of the repository sitting around anymore.

  1. Is it ok to delete the repository before my pull request gets looked at by the user?

  2. If I do delete my forked repository now, will my pull request still be applicable?

  3. Is deleting forked repositories before the pull requests gets analysed, an ok practice?

Nevik Rehnel
  • 49,633
  • 6
  • 60
  • 50
Trevor Hickey
  • 36,288
  • 32
  • 162
  • 271

2 Answers2

23
  1. Yes
  2. Yes

The pull request(PR) is unaffected when you delete your fork (see also this answer to a similar question).

  3. It depends:

Once your fork is deleted, the PR contents (commits) can no longer be updated in the same PR thread. You can fix your commit even after you have deleted (and possibly recreated) your fork, as your commit exists in the upstream repository. However, the existing PR will not update even if you create a branch of the same name in a recreated fork, so you will have to open a new PR (the requesting branch and fork are internally linked to a unique identifier; recreating a fork will generate a new identifier, so the PR remains unlinked).

So if you can expect to get feedback on the PR within a reasonable time (and if you intend to consider the feedback and fix your contribution, if necessary), you should keep your fork so you can fix your contribution, if necessary.

If you don't expect feedback or don't care about fixing your contribution, you can delete your fork right away.

Community
  • 1
  • 1
Nevik Rehnel
  • 49,633
  • 6
  • 60
  • 50
  • I suppose the answer should be updated? I don't know what the behavior was at the time this question was answered, but today when a fork is deleted while it has a non-merged PR upstream, the PR is automatically closed. – Delgan Jun 10 '23 at 14:19
2

When your fork is deleted, your pull requests are automatically closed.

Nikolai
  • 3,053
  • 3
  • 24
  • 33