DataTableReader.GetValue(int) is throwing ArguementOutOfRangeException

Question

In a section of my code I use a DataTable and a DataTableReader to get information from my SQLite database and add it to a list. When the program gets to the reader.GetValue line the program throws an ArgumentOutOfRangeException. As far as I've been able to tell there is no reason for this to be happening.

    DataTable dt = db.GetDataTable(Program.CONN, "SELECT ID FROM table WHERE column LIKE 'False%'");
    using (DataTableReader dtr = dt.CreateDataReader())
    {
         while (dtr.Read())
         {
              int rt = 0;
              foreach (DataRow dr in dt.Rows)
              {
                   string line = dtr.GetValue(rt).ToString();//Arguement out of range exception being thrown here
                   idList.Add(line);
                   rt++;
              }
          }
     }

Plue · Accepted Answer · 2014-01-15T15:01:17.653

3

You are iterating through the rows, not the columns. You should do :

DataTable dt = db.GetDataTable(Program.CONN, "SELECT ID FROM table WHERE column LIKE 'False%'");
int count = dt.Columns.Count;
using (DataTableReader dtr = dt.CreateDataReader())
{
    while (dtr.Read())
    {
        for (int rt = 0 ; rt < count ; rt ++)
        {
            string line = dtr.GetValue(rt).ToString();
            idList.Add(line);
        }
     }
}

Or :

DataTable dt = db.GetDataTable(Program.CONN, "SELECT ID FROM table WHERE column LIKE 'False%'");
using (DataTableReader dtr = dt.CreateDataReader())
{
    while (dtr.Read())
    {
        foreach (DataColumn col in dt.Columns)
        {
            string line = dtr[col.ColumnName].ToString();
            idList.Add(line);
        }
    }
}

edited Jan 15 '14 at 15:01

answered Jan 15 '14 at 14:36

Plue

1,739
1
18
22

Not really. I followed his syntax but it would be better to use a for loop – Plue Jan 15 '14 at 14:39
@LarsTech Are you sure that **dtr[col.ColumnName]** works with DataTableReader? – Plue Jan 15 '14 at 14:49
I missed the columns vs rows thing. A'aaack, good catch. Up vote. – granadaCoder Jan 15 '14 at 14:59

granadaCoder · Answer 2 · 2014-01-15T15:02:23.797

0

int fc = dataReader.FieldCount;
while (dtr.Read())
{
  for (int rt = 0 ; rt < fc ; rt ++)
  {
     if (fc > rt)
     {
         if (!(dtr.IsDBNull(rt)))
         {
            string line = dtr.GetValue(rt).ToString();
            idList.Add(line);
         }
      }
   }
}

edited Jan 15 '14 at 15:02

answered Jan 15 '14 at 14:33

granadaCoder

26,328
10
113
146

I edited my answer......... I like the inclusion of if (!(dtr.IsDBNull(rt))) { ) but that's me. My edits were also because of Plue's "catch", so that answer should be given credit. However, I leave this answer here....just in case. – granadaCoder Jan 15 '14 at 15:04

DataTableReader.GetValue(int) is throwing ArguementOutOfRangeException

2 Answers2