OnClickListener gets triggered when button in another place

Question

I have four ImageButtons in my app.

enter image description here

Three smaller buttons can be either shown or "hidden" below the bigger button. I hide buttons using rotate and translate animations.

The problem is: OnClickListener's onClick method always gets triggered no matter a smaller button shown or not.

I mean, when smaller buttons are "hidden", touching the place on screen, where one of the smaller button resides when shown, triggers onClick method.

It looks like Android OS does not take actual placement of the button into account when deciding whether it should trigger onClick method or not.

How can I overcome the issue?

I want onClick method to be called ONLY when there is a button below my finger.

EDIT:

All suggested workarounds rely on hiding the button. This doesn't help at all. The onClick method gets called for INVISIBLE and GONE buttons too. I checked this in debugger.

Might be problem of reference .. Your button might be not getting proper reference at time of click. — AndroidHacker, Jan 13 '14 at 11:51
put a condition in onClick `if(view.isShown()){// perform opertaions}` — Sunny, Jan 13 '14 at 11:52
@AndroidHacker I am not sure what are you talking about. Would you care to elaborate on that? — Bobrovsky, Jan 13 '14 at 11:56
@Sunny this won't help because the button is shown (just moved below other button). — Bobrovsky, Jan 13 '14 at 11:57
i.e Might be you are not getting view on click. I can more specific on this if you manage to post code over here — AndroidHacker, Jan 13 '14 at 11:59
i.e Might be you are not getting view on click. I can be more specific on this if you manage to post code over here — AndroidHacker, Jan 13 '14 at 12:01

score 1 · Answer 1 · answered Jan 13 '14 at 12:02

1

Looks like you are going for an Arc menu. Why not use the awesome implementations of Siyamed and DaCapricorn, instead of re-inventing the wheel?

answered Jan 13 '14 at 12:02

Srikanth

2,014
19
22

Thank you for the links. Projects look great and I might be using them in one of my other applications. – Bobrovsky Jan 13 '14 at 12:18

score 1 · Answer 2 · answered Jan 13 '14 at 12:36

1

Did you set your click interface your activity and implemented onClickListener? If so you need to separated your buttons by setting if conditions like if(arg0 == button1) for all the buttons.

answered Jan 13 '14 at 12:36

Barışcan Kayaoğlu

1,294
3
14
35

score 1 · Accepted Answer · answered Jan 14 '14 at 09:35

1

The issue was caused by the fact that tween animations (the original animation framework) animate the pixels, not the touch zones of a widget.

I have replaced tween animations with property animations and now everything works like I expect it to work.

answered Jan 14 '14 at 09:35

Bobrovsky

13,789
19
80
130

18446744073709551615 · Answer 4 · 2014-01-14T05:23:35.713

0

I'd suggest setting the button visibility to GONE after completing the animation.

UPDATE:

Another suggestion is to have a button that is not animated (for which the problem should not happen) and an image (graphically identical) that is animated after the button is hidden. The image should not receive any clicks, under the big button or not, and the real button should not receive clicks when hidden.

edited Jan 14 '14 at 05:23

answered Jan 13 '14 at 11:57

18446744073709551615

16,368
4
94
127

Unfortunately, this didn't helped. The button is hidden but onClick gets called. – Bobrovsky Jan 13 '14 at 12:19
Are you sure that the thing that responds to the clicks is the button? I can imagine transparent click areas above buttons, parent views taking care about all clicks and redirecting the calls, etc. What is the view passed to onClick? And what in the stack trace printed by _new Exception().printStackTrace()_? – 18446744073709551615 Jan 13 '14 at 12:23
in `onClick` handler the view is image button, the `v.isShown() == false` and `v.getVisibility == 4` (or 8) – Bobrovsky Jan 13 '14 at 12:25
Then just ignore clicks coming from buttons whose `v.isShown() == false` – 18446744073709551615 Jan 13 '14 at 12:28
or, set its "clickable" to false. – 18446744073709551615 Jan 13 '14 at 12:29
One more suggestion is to clean and rebuild :) -- just in case you didn't do this – 18446744073709551615 Jan 13 '14 at 12:30

score 0 · Answer 5 · answered Jan 13 '14 at 11:59

0

Setting

btn.setVisibility(View.INVISIBLE);

doesn't call onClick method where buttons are not visible. I have tested it. So you might be registering onClick listener in unnecessary views.

answered Jan 13 '14 at 11:59

Bipin Bhandari

2,694
23
38

I checked and I get onClick called for hidden buttons. – Bobrovsky Jan 13 '14 at 12:19
Now it is almost impossible to answer without code? Just show some relevant part of the code – Bipin Bhandari Jan 13 '14 at 12:22

score 0 · Answer 6 · answered Jan 13 '14 at 12:07

Try to set the listener using the property onClick of the button in the layout.xml (for example

android:onClick="onClickButtonCamera"

and then declare a public function with the same name like:

public void onClickButtonCamera(View view) {
    //some stuff...
}

I allways use it and the function is never called when the buttons are hidden. I hope it helps you.

score 0 · Answer 7 · answered Jan 13 '14 at 13:32

i think there are three ways to solve this issue.

1) if you are setting onClick Listener then set it null when you hide buttons and set listener when you show them.

2)Add a checking in onclick for each button about their visibility simply return; the function when button's visibility is not VISIBLE(use the function button.getVisibility() != View.VISIBLE)

3)Last one not sure, usually setting gone as visibility will protect it from clicking.

OnClickListener gets triggered when button in another place

7 Answers7