if statement with && and || in objective c

Question

I'm wondering what's wrong with the following, or how to fix the brackets correctly:

if (([newCharacter isEqual: @"ö"]||[newCharacter isEqual: @"Ö"]) && (self.currentLanguage isEqual @"Finnish/Swedish")){
//do something
}

the error says I should place parantheses somewhere... but I cannot figure out how. Can anyone help?

syntax error... add braces [self.currentLanguare isEqual:@""]; — Adnan Aftab, Jan 11 '14 at 16:47

score 2 · Accepted Answer · answered Jan 11 '14 at 16:41

2

If you change this:

(self.currentLanguage isEqual @"Finnish/Swedish")

to this:

[self.currentLanguage isEqual:@"Finnish/Swedish"]

you should be ok. You need square brackets and a colon there to have a proper expression for sending the isEqual message, and no extra () parentheses are needed after the &&.

answered Jan 11 '14 at 16:41

Mike Mertsock

11,825
7
42
75

I don't think it's true that using `isEqual:` means you will only compare memory addresses. Both `isEqual:` and `isEqualToString:` should have the same results for any comparison of two string objects. @viperking's answer links to a good discussion on this. In short, I'd say that for most code it really doesn't make a meaningful difference other than style preferences. – Mike Mertsock Jan 12 '14 at 16:25

score 1 · Answer 2 · edited May 23 '17 at 12:13

You are missing : after isEqual in this: self.currentLanguage isEqual @"Finnish/Swedish"

So your code should looks like:

if (([newCharacter isEqual: @"ö"]||[newCharacter isEqual: @"Ö"]) && (self.currentLanguage isEqual: @"Finnish/Swedish")){
   //do something
}

I would also recommend you a change of isEqual: to isEqualToString: as it is more obvious what are you comparing and also has some performance issues according to this question

if statement with && and || in objective c

2 Answers2