8

I have the following code that reads the content of a url

public static String DownloadText(String url){
    StringBuffer result = new StringBuffer();
    try{
        URL jsonUrl = new URL(url);

        InputStreamReader isr  = new InputStreamReader(jsonUrl.openStream());

        BufferedReader in = new BufferedReader(isr);

        String inputLine;

        while ((inputLine = in.readLine()) != null){
            result.append(inputLine);
        }
    }catch(Exception ex){
        result = new StringBuffer("TIMEOUT");
        Log.e(Util.AppName, ex.toString());
    }
        in.close();
        isr.close();
    return result.toString();
}

The problem is I am missing content after 4065 characters in the result returned. Can someone help me solve this problem.

Note: The url I am trying to read contains a json response so everything is in one line I think thats why I am having some content missing.

Janusz
  • 187,060
  • 113
  • 301
  • 369
Josnidhin
  • 12,469
  • 9
  • 42
  • 61

2 Answers2

10

Try this:

try {
  feedUrl = new URL(url).openConnection();
} catch (MalformedURLException e) {
  Log.v("ERROR","MALFORMED URL EXCEPTION");
} catch (IOException e) {
  e.printStackTrace();
}
try {
  in = feedUrl.getInputStream();
  json = convertStreamToString(in);
}catch(Exception e){}

while convertStreamToString is:

private static String convertStreamToString(InputStream is) throws UnsupportedEncodingException {
  BufferedReader reader = new BufferedReader(new InputStreamReader(is,"UTF-8"));
  StringBuilder sb = new StringBuilder();
  String line = null;
  try {
    while ((line = reader.readLine()) != null) {
      sb.append(line + "\n");
    }
  } catch (IOException e) {
    e.printStackTrace();
  } finally {
    try {
      is.close();
  } catch (IOException e) {
    e.printStackTrace();
  }
}
return sb.toString();
 }
asish
  • 4,767
  • 4
  • 29
  • 49
lbedogni
  • 7,917
  • 8
  • 30
  • 51
3

Here is a cleaner version to fetch the output of a script from the web:

public String getOnline(String urlString) {
    URLConnection feedUrl;
    try {
        feedUrl = new URL(urlString).openConnection();
        InputStream is = feedUrl.getInputStream();

        BufferedReader reader = new BufferedReader(new InputStreamReader(is,"UTF-8"));
        StringBuilder sb = new StringBuilder();
        String line = null;

        while ((line = reader.readLine()) != null) {
            sb.append(line + "");
        }
        is.close();

        return sb.toString();

    }catch(Exception e){
        e.printStackTrace();
    }

    return null;
}

And remember that you cannot download anything from the main thread. It has to be from a separate thread. Use something like:

new Thread(new Runnable(){
            public void run(){

                if(!isNetworkAvailable()){
                    Toast.makeText(getApplicationContext(), getResources().getString(R.string.nointernet), Toast.LENGTH_LONG).show();
                    return;
                }

                String str=getOnline("http://www.example.com/script.php");

            }
        }).start();
dev4life
  • 10,785
  • 6
  • 60
  • 73