jQuery data function usage with keywords

Question

My HTML:

 <a id="link" class="linkRedirect" data-href="">Download Link</a>

I am getting incorrect value for $("#link").data("href") when clicked multiple times.

Click Handler:

 $(document).on("click", "#link", function (e) {
            var url = $("#link").data("href");
            //check validation
            if(true) location.href = url;
 });

The file in the url will be downloaded only if the session is valid.

@crack Its a download link. When user clicks, some token validation is done; if success download the file. — Joseph, Jan 03 '14 at 08:51
@Gourav If I use href directly, I cannot validate the token. — Joseph, Jan 03 '14 at 08:52

score 0 · Answer 1 · answered Jan 03 '14 at 09:37

You could rather use it like this:

<a id="link" class="linkRedirect" rel="somelink">Download Link</a>

then ins your jquery, use this:

 $(document).on("click", "#link", function (e) {
            var url = $("#link").attr("rel");
            //check validation
            if(url)//apply whatever check you want
             location.href = url;
 });

score 0 · Answer 2 · answered Jan 03 '14 at 09:37

0

Your jQuery code is really weird. Anyway check with that:

$('#link').click(function(){
  var url = $("#link").attr("data-href"); 
  if(url){
    window.location = url;
  }
});

I didn't test it but that would work better than your code :)

answered Jan 03 '14 at 09:37

enguerranws

8,087
8
49
97

Thanks. It works. The issue occurs when data function is used – Joseph Jan 06 '14 at 03:24

score 0 · Answer 3 · answered Jan 06 '14 at 03:25

0

Got the problem. When I renamed attribute data-href to data-url, the issue was solved.

$("#link").data("href")

The value obtained was that of href attribute and not data-href.

answered Jan 06 '14 at 03:25

Joseph

91
1
7

jQuery data function usage with keywords

3 Answers3