-1

So I got this project to take a page that was previously using MySQL and now using Oracle. So I installed the oci8 PHP module and created a test page to make my changes on. This is a page I am updating and I am not an Oracle guy. I am a MySQL/PostgreSQL guy.

Anyway, there are these original parameters:

$webIndex = mysql_db_query('main', 'SELECT * FROM links2');
while ($garbage = mysql_fetch_array($webIndex)) {
    $descriptions = $garbage['descr'];
    $urls = $garbage['url'];
    print "<a href=\"$urls\">$descriptions</a><br />";
    $i++;
}

So I replaced the lines as follows:

$webIndex = oci_parse('main', 'SELECT * FROM links2');
while ($garbage = oci_fetch_array($webIndex)) {
    $descriptions = $garbage['descr'];
    $urls = $garbage['url'];
    print "<a href=\"$urls\">$descriptions</a><br />";
    $i++;
}

Upon doing this, tailed -f the apache error log and got:

[Thu Jan 02 14:41:24 2014] [error] [client 10.10.102.75] PHP Warning:  oci_parse() expects parameter 1 to be resource, string given in /srv/www/htdocs/db/index-woods.php on line 15
[Thu Jan 02 14:41:24 2014] [error] [client 10.10.102.75] PHP Warning:  oci_fetch_array() expects parameter 1 to be resource, null given in /srv/www/htdocs/db/index-woods.php on line 17
[Thu Jan 02 14:41:24 2014] [error] [client 10.10.102.75] PHP Notice:  Undefined variable: pageText2 in /srv/www/htdocs/db/index-woods.php on line 105
[Thu Jan 02 14:41:24 2014] [error] [client 10.10.102.75] PHP Notice:  Undefined variable: pageText3 in /srv/www/htdocs/db/index-woods.php on line 106

The last two errors are related to the first two. Based on these errors, it appears that oci_parse and oci_fetch_array are incorrect. These are lines 15 and 17 BTW.

Once again I do not know Oracle...

Palec
  • 12,743
  • 8
  • 69
  • 138
NerdyBird
  • 109
  • 1
  • 5
  • 11
  • 1
    Start with [the docs on `oci_parse()`](http://us1.php.net/manual/en/function.oci-parse.php) The first argument is a connection link resource, not a string. `mysql_db_query()` was an old deprecated function and it doesn't have a drop-in replacement under `oci_*()` – Michael Berkowski Jan 02 '14 at 21:06
  • This is not about Oracle, but about your use of the PHP functions. Read the error messages and correct the calls to the functions you're making. –  Jan 02 '14 at 21:07
  • The `oci_parse()` docs have examples on how a statement is prepared, executed, and rows fetched. It's somewhat different than your old code. – Michael Berkowski Jan 02 '14 at 21:08
  • 2
    Since you're rewriting code, you may be better off using the more portable [`PDO`](http://www.php.net/manual/en/intro.pdo.php) with Oracle than the old `oci_*()` extension. – Michael Berkowski Jan 02 '14 at 21:09

1 Answers1

1

This has nothing to do with knowing Oracle or not. This has to do with knowing PHP.

PHP Warning: oci_parse() expects parameter 1 to be resource, string given in /srv/www/htdocs/db/index-woods.php on line 15

You should learn that this PHP is warning about parameter type, and be able to look up the function arguments in the manual.

If you look at the documentation for oci_parse(), you'll see that the first argument should be a connection resource, which you get from oci_connect(). There's also a code example of using oci_connect(), and subsequently using the $conn as the first argument to oci_parse().

The following errors in your log are all due to the fact that the call to oci_parse() did not work.

Always check the return value for each of oci_parse() and oci_execute() because if there's any problem, those functions return false (this is also stated in the manual). The false value cannot be used as a query resource in subsequent calls to oci_fetch_array() and other functions.

See examples of checking for errors here: http://php.net/manual/en/function.oci-error.php

Bill Karwin
  • 538,548
  • 86
  • 673
  • 828