read violation while accessing to a vector which is for an object

Question

this is a c++ question.

I'm working on an OpenGL project. wrote a simple OBJ loader. I have a class called Mesh. By getting an object pointer called monkey

Mesh* monkey;

and calling function:

load_obj("Monkey.obj", monkey);

I want to read from file and put it in monkey vertices. but when running it gives me unhandled exception:read violation when want to pushback to vector at:

mesh->vertices.push_back(v);

I tested a local vector dummy but it successfully pushedback. I don't know why it can't push to the object pointers vector?

here is the mesh header

include[...]

using namespace std;

class Mesh {
private:
  GLuint vbo_vertices, vbo_normals, ibo_elements;
public:
  vector <glm::vec4> vertices;
  vector <glm::vec3> normals;
  vector <GLushort> elements;
  glm::mat4 object2world;

  Mesh() : vertices(1), normals(1), elements(3), object2world(glm::mat4(1)) {}
  ~Mesh(void){} ;
  void Mesh::draw(void) ;

};

and this is the obj-loader.cpp relative part

void load_obj(const char* filename, Mesh* mesh) {
  ifstream in(filename, ios::in);
  if (!in) { cerr << "Cannot open " << filename << endl; exit(1); }
  vector<int> nb_seen;
  vector<glm::vec4> dummy;
  string line;
  while (getline(in, line)) {
    if (line.substr(0,2) == "v ") {
      istringstream s(line.substr(2));
      glm::vec4 v; s >> v.x; s >> v.y; s >> v.z; v.w = 1.0;
      dummy.push_back(v);
      mesh->vertices.push_back(v);
    }

any help would be appreciated! your confused friend!

score 1 · Answer 1 · answered Dec 28 '13 at 13:16

1

You will have to allocate memory for Mesh

before calling

load_obj("Monkey.obj", monkey);

answered Dec 28 '13 at 13:16

Digital_Reality

4,488
1
29
31

score 0 · Answer 2 · answered Dec 28 '13 at 13:13

0

mesh is an uninitialized pointer on which you are using mesh->vertices. You got undefined behavior at this point already. You probably need have mesh point to an object.

answered Dec 28 '13 at 13:13

Dietmar Kühl

150,225
13
225
380

score 0 · Accepted Answer · answered Dec 28 '13 at 13:14

From the code fragments you have posted, it appears that you haven't actually allocated the mesh object. Declaring the pointer like this:

Mesh* monkey;

doesn't initialise the pointer or allocate any memory, so its value is undefined. That's why the loading code is crashing. Because the mesh pointer is invalid, and pointing to some garbage memory.

It should be something more like:

Mesh* monkey = new Mesh();

Then at least you will have a valid pointer which you can then legitimately refer to in the loader code.

heh, now I remember. we had c++ course last year you know!! :-/ many tnx gavinb! — Hafez Mousavi, Dec 28 '13 at 13:29

read violation while accessing to a vector which is for an object

3 Answers3