Combining DetailView and CreateView in Django 1.6

Question

I have 2 separate models, Post and Comment. I use DetailView to display Post contents and I want to use a CreateView to display comment creation form on the same page. What is the cleanest way to go about that?

The only thing that comes to mind is to use custom view which both gets an object and processes comment form, but this looks too dirty:

def post_detail(request, slug):
    post = get_object_or_404(Post, slug=slug)
    if request.POST:
        form = CommentForm(request.POST)
        # do comment form processing here
    return render(request, "post/post_detail.html", {
        "object": post, "comment_form": form})

Is there any clean way to do this using class based views? Or just some way to decouple post display code from comment processing code?

What's dirty about this view? If it's the fact that you are having both `GET` and `POST` mixed in together, try `django.views.generic.base.View`. Or create templatetags to generate comment forms for objects (like old `django.contrib.comments` used to have). — Maciej Gol, Dec 26 '13 at 13:59
@kroolik What dirty is that my Comment and Post models logic is not decoupled. I do like the templatetags idea though. This way I can have separate view for creating comments. — Ruslan Osipov, Dec 26 '13 at 14:00
You can see how it's done [here](https://github.com/django/django/blob/master/django/contrib/comments/templatetags/comments.py) — Maciej Gol, Dec 26 '13 at 14:04

score 4 · Answer 1 · edited Apr 23 '20 at 08:47

It is possible to combine DetailView and CreateView. You use a class for DetailView and another class for CreateView, then you create a new class that inherits from View. This new class has a get and post method. The get method calls the DetailView while the post method calls the CreateView. Take note to use reverse_lazy for the success_url in CreateView. So basically your code should look something like this:

class PostView(DetailView):
    # your code 
    pass ;

class CommentView(CreateView):
    def get_success_url(self):
        return reverse_lazy('post_detail', kwargs={'pk': self.get_object(Post.objects.all().pk})

class PostCommentView(View):
    def get(self, request, *args, **kwargs):
         view = PostView.as_view()
         return view(request, *args, **kwargs) 

    def post(self, request, *args, **kwargs) :
         view = CommentView.as_view()
         return view(request, *args, **kwargs)

So your urls.py will point to

PostCommentView

I did an override of get_success_url because it will try to go to the detail view of the new comment which doesn't exist and is not what you want to do. So the override will take you to the DetailView of the post instead.

There is an explanation in the documentation.

score 3 · Accepted Answer · answered Dec 30 '13 at 15:53

3

One option would be to use the DetailView for the Post and a templatetag to display the comment form. Have the comment form submit to a Comment CreateView that redirects to the DetailView on success.

That said, it might get a little ugly if the form is invalid. In a pinch you can always call a DetailView or its methods from one of the CreateView methods. But IMO that introduces more coupling rather than less. Or you could have a separate utility function that you can call from the CreateView to display the Post if the comment form has errors.

Another option would be to use AJAX to process the comment form (in the separate CreateView) instead of a new page load.

In the end, regardless of language or framework, there's going to be a limit to how much one can decouple a view that needs to display one object type and create another.

answered Dec 30 '13 at 15:53

spoon

46
2

AJAX is a bit too nasty, but the template tag was my solution. I used an idea from here: https://github.com/django/django/blob/master/django/contrib/comments/templatetags/comments.py (thanks to @kroolik). Here's what I did at the end: https://github.com/ruslanosipov/rblog/blob/master/comment/templatetags/comments.py – Ruslan Osipov Dec 30 '13 at 21:28
I like that solution -- it might even be further generalizable to any model that needs to be edited in another's DetailView. So now I'm curious: how are you handling cases in which the comment form fails to validate? – spoon Dec 31 '13 at 21:02
I take a user to the separate page where she/he can edit the comment: https://github.com/ruslanosipov/rblog/blob/master/comment/views.py. But not using AJAX is just a personal choice. – Ruslan Osipov Jan 01 '14 at 03:38
Nothing wrong with that choice -- it's one I've also made at times in the past. I also like graceful degradation: even if you eventually add in AJAX, it's valuable to be able to handle the case where the user has javascript disabled. – spoon Jan 01 '14 at 15:45
1

@RuslanOsipov the first two links you provided are no longer available. – therealak12 Apr 23 '20 at 06:21
@AK12 To be honest, I don't even recall what it was 6 years later. – Ruslan Osipov Apr 24 '20 at 22:58

Combining DetailView and CreateView in Django 1.6

2 Answers2

Linked