No value given for one or more required parameters. during paramatized search

Question

I am trying a paramatized search to prevent sql injection. However the error "No value given for one or more required parameters". comes

     Dim sql As String
    Call connect()
    con.Open()
    sql = "Select * from Records where Customer_ID=@CustomerID"
    cmd.Parameters.AddWithValue("@CustomerID", Txt_Customer_ID.Text)
    cmd = New OleDbCommand(sql, con)
    dr = cmd.ExecuteReader
    While dr.Read
        Txt_Customer_ID.Text = dr(0)
        Txt_Customer_Name.Text = dr(1)
        Txt_Customer_Contact.Text = dr(2)
        Txt_Delivery_Method.Text = dr(3)
        Txt_Reference.Text = dr(4)
    End While

    con.Close()

The Customer_ID field in the database is a text type and I need to know how to finish this search without running into the error

I am doing this in a test database that has only one table and I have copy pasted the table and field name. — Ahmed Faizan, Dec 24 '13 at 20:38

score 2 · Accepted Answer · answered Dec 24 '13 at 20:48

Got the answer! Thank you to everyone who tried

  cmd.Parameters.AddWithValue("@CustomerID", Txt_Customer_ID.Text)

line must be below

cmd = New OleDbCommand(sql, con)

Here is the code that works

 Dim sql As String
    Call connect()
    con.Open()
    sql = "Select * from Records where Customer_ID=@CustomerID"

    cmd = New OleDbCommand("Select * from Records where Customer_ID=@CustomerID", con)
    cmd.Parameters.AddWithValue("@CustomerID", Txt_Customer_ID.Text)
    dr = cmd.ExecuteReader
    While dr.Read
        Txt_Customer_ID.Text = dr(0)
        Txt_Customer_Name.Text = dr(1)
        Txt_Customer_Contact.Text = dr(2)
        Txt_Delivery_Method.Text = dr(3)
        Txt_Reference.Text = dr(4)
    End While

    con.Close()

Al-3sli · Answer 2 · 2013-12-24T20:58:39.307

1

Change the order like this

     cmd = New OleDbCommand(sql, con)
    cmd.Parameters.AddWithValue("@CustomerID", Txt_Customer_ID.Text)

edited Dec 24 '13 at 20:58

answered Dec 24 '13 at 20:26

Al-3sli

2,161
2
15
19

Thank you but can you show how to do other way. I am learning how to do that for now. – Ahmed Faizan Dec 24 '13 at 20:31
What you mean "how to do other way?"?? – Al-3sli Dec 24 '13 at 20:37
The method in the question. Is there an error in the code I have done. like missing characters like '' or "" . – Ahmed Faizan Dec 24 '13 at 20:42
cmd.Parameters.AddWithValue("@CustomerID", Txt_Customer_ID.Text) cmd = New OleDbCommand(sql, con). Do new inislize before create parameter – Al-3sli Dec 24 '13 at 20:50

No value given for one or more required parameters. during paramatized search

2 Answers2