I don't know what is wrong with my syntax

Question

Here's my code;

def save(name):
    if x['fname'] == 'ply.json':
        save1(name)
    elif x['fname'] not 'ply.json':
        write_data({'fname':'ply.json', 'name':'Karatepig'}, 'ply.json')

I get an error stating that I have this syntax error:

File "<stdin>", line 4
  elif x['fname'] not 'ply.json':
                               ^

What am I doing wrong?

This question should be closed because it is predicated on a typo and will have no utility for future readers. — jscs, Dec 23 '13 at 02:20

score 1 · Accepted Answer · answered Dec 22 '13 at 19:07

1

something not something is not a valid expression. If you want to test if it is not equal, use !=:

elif x['fname'] != 'ply.json':

However, since this is the exact opposite of the preceding if test, just use else here:

if x['fname'] == 'ply.json':
    save1(name)
else:
    write_data({'fname':'ply.json', 'name':'Karatepig'}, 'ply.json')

answered Dec 22 '13 at 19:07

Martijn Pieters

1,048,767
296
4,058
3,343

Thanks again, you're so fast in your answers, heh. – Karatepig Dec 22 '13 at 19:09

score 1 · Answer 2 · answered Dec 22 '13 at 19:07

1

You need to use != to test inequality, like this:

    elif x['fname'] != 'ply.json':

But why use elif?

def save(name):
    if x['fname'] == 'ply.json':
        save1(name)
    else:
        write_data({'fname':'ply.json', 'name':'Karatepig'}, 'ply.json)

answered Dec 22 '13 at 19:07

tckmn

57,719
27
114
156

Using else for something else later. Thanks though. – Karatepig Dec 22 '13 at 19:08
@Karatepig but there isn't any other else. The thing is either equal, or it isn't. – Daniel Roseman Dec 22 '13 at 19:10
@DanielRoseman I'm going to use else to check for an "invalid" fname and change it to one that I'm considering "valid". – Karatepig Dec 22 '13 at 19:12
But it will never arrive there, since one of the first two conditions will always be true. – Daniel Roseman Dec 22 '13 at 19:24
@Kara Daniel was trying to say that it can only either be equal or not equal, so it will never reach the `else` because it can't be equal and not equal at the same time. – tckmn Dec 22 '13 at 19:29
@DanielRoseman Oh I see. You're right. I apologise. – Karatepig Dec 22 '13 at 19:33
@DoorknobofSnow Thanks for clearing that up. – Karatepig Dec 22 '13 at 19:33

score 0 · Answer 3 · edited May 23 '17 at 12:06

0

You need to use != for "not equal":

elif x['fname'] != 'ply.json':

edited May 23 '17 at 12:06

Community

1
1

answered Dec 22 '13 at 19:07

I don't know what is wrong with my syntax

3 Answers3