Random Array Item and Set as Embed SRC

Question

I'm attempting to creating a music player that plays a random song by choose a random item from an array and setting it and other things, via concatenation, as the embed's src.

<script type="text/javascript">
    //Playlist
    var musicArray = ['b.mp3', 'b2.mp3', 'b3.mp3'];
    //src vars
    var first = 'niftyplayer.swf?file=';
    var last = '&as=1';
    // Shuffle
    var mid = musicArray[Math.floor(Math.random() * myArray.length)];
    //Set src
    getElementById("embed").src='first+mid+last';
    getElementById("param").value='first+mid+last';
</script>
<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,0,  0" width="165" height="38" id="niftyPlayer1" align="">
    <param id="param" name=movie value="">
    <param name=quality value=high>
    <param name=bgcolor value=#FFFFFF>
    <embed id="embed" src="" quality=high bgcolor=#FFFFFF width="165" height="38" name="niftyPlayer1" align="" type="application/x-shockwave-flash" pluginspage="http://www.macromedia.com/go/getflashplayer">
    </embed>
</object>
<script type="text/javascript" language="javascript" src="niftyplayer.js"></script>

However, my script does not work.

JSFiddle of niftyplayer.js

Does it work if you put src in embed manually? not using javascript — Mujtaba Haider, Dec 19 '13 at 01:56
1. remove single quotes around `first+mid+last` 2. you're trying to set properties of DOM objects which are not loaded at the time of js execution — Iłya Bursov, Dec 19 '13 at 01:59

score 0 · Answer 1 · answered Dec 19 '13 at 02:00

0

Put the javascript code after html, and remove quotes from below lines 'first+mid+last'

getElementById("embed").src= first+mid+last;
    getElementById("param").value= first+mid+last;

answered Dec 19 '13 at 02:00

Mujtaba Haider

1,650
2
19
29

score 0 · Accepted Answer · answered Dec 19 '13 at 02:03

In this case, load js after html. Then, fix your 'embed' and 'param'.

-- code below.

<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,0,  0" width="165" height="38" id="niftyPlayer1" align="">
    <param id="param" name=movie value="">
    <param name=quality value=high>
    <param name=bgcolor value=#FFFFFF>
    <embed id="embed" src="" quality=high bgcolor=#FFFFFF width="165" height="38" name="niftyPlayer1" align="" type="application/x-shockwave-flash" pluginspage="http://www.macromedia.com/go/getflashplayer">
    </embed>
</object>
<script type="text/javascript" language="javascript" src="niftyplayer.js"></script>

    <script type="text/javascript">
    //Playlist
    var musicArray = ['b.mp3', 'b2.mp3', 'b3.mp3'];
    //src vars
    var first = 'niftyplayer.swf?file=';
    var last = '&as=1';
    // Shuffle
    var mid = musicArray[Math.floor(Math.random() * myArray.length)];
    //Set src
    getElementById("embed").src = first + mid + last;
    getElementById("param").value = first + mid + last;
</script>

Random Array Item and Set as Embed SRC

2 Answers2