Android : Can't create handler inside thread that has not called Looper.prepare()

Question

In my app I have a sercice class that it has this method to show progress dialog when do something :

private void openprogresdialog() {

new AsyncTask<Integer, Integer, Boolean>()
{
    ProgressDialog progressDialog;

    @Override
    protected void onPreExecute()
    {
        progressDialog = ProgressDialog.show(thisActivity, "Dialog","Loading...");
    }

    @Override
    protected Boolean doInBackground(Integer... params)
    {
        if (params == null)
        {
            return false;
        }
        try
        {
            Thread.sleep(params[0]);
        }
        catch (Exception e)
        {
            Log.e("tag", e.getMessage());
            return false;
        }

        return true;
    }

    @Override
    protected void onPostExecute(Boolean result)
    {
        progressDialog.dismiss();
        AlertDialog.Builder b = new AlertDialog.Builder(thisActivity);
        b.setTitle(android.R.string.dialog_alert_title);
        if (result)
        {
            b.setMessage("Download succeeded");
        }
        else
        {
            b.setMessage("Download failed");
        }
        b.setPositiveButton(getString(android.R.string.ok),
                new DialogInterface.OnClickListener()
                {

                    @Override
                    public void onClick(DialogInterface dlg, int arg1)
                    {
                        dlg.dismiss();
                    }
                });
        b.create().show();
    }
}.execute(2000);

new Thread()
{
    @Override
    public void run()
    {

        DialogInterface progressDialog = null;
        progressDialog.dismiss();
    }
}.start();
}

I want that while app do it's work progress dialog will show but when i run app i get this error :

Can't create handler inside thread that has not called Looper.prepare()

How can i fix it?

EDIT :

public class MyService extends Service {
    private static final String TAG = "MyService";
    Thread readthread;
    final MyService thisActivity = this;
    public IBinder onBind(Intent intent) {
        return null;
    }

    @Override
    public int onStartCommand(Intent intent, int flags, int startId) {
        final ParentActivityData data = intent.getParcelableExtra("DATA");

        readthread = new Thread(new Runnable() {
            public void run() {
                // SOME CODE TO EXECUTE //
                }
                openprogresdialog();
            }
        });

        readthread.start();

        Log.d(TAG, "onCreate");

        return super.onStartCommand(intent, flags, startId);
    }

    @Override
    public void onCreate() {
    }

    @Override
    public void onDestroy() {

    }
}

`progressDialog.dismiss();` this in thread. remove the thread itself — Raghunandan, Dec 17 '13 at 08:55

score 1 · Answer 1 · answered Dec 17 '13 at 09:02

1

Although adding Looper.prepare() is probably a valid option, I'd rather add use Activity#runOnUIThread if thats possible here. Also, why are you using a thread anyway?

It's not necessary to use a thread here.

Btw: Your code

DialogInterface progressDialog = null;
progressDialog.dismiss();

will produce a NullpointerException...

answered Dec 17 '13 at 09:02

Lovis

9,513
5
31
47

so what am i doing instead of it? – Elham Gdz Dec 17 '13 at 09:13
@ElhamGdz after your edit, my answer is now invalid. – Lovis Dec 17 '13 at 09:14

Raghunandan · Accepted Answer · 2013-12-17T09:18:26.093

You have

readthread = new Thread(new Runnable() {
            public void run() {

In the thread's run method you ahve

openprogresdialog();

In openprogresdialog you have a Asynctask and a thread.

Asynctask must be loaded on the ui thread. Check the topic Threading Rules in the link below.

http://developer.android.com/reference/android/os/AsyncTask.html

Can't create handler inside thread that has not called Looper.prepare()

You cannot update ui in a background thread. Ui should be updated on the ui thread. Your Asynctask looks fine but must be loaded on the ui thread.

Also remove the below which is useless. Will also give NullPointerException since progressDialog is not initialized and you call dismiss before initialization

new Thread()
{
    @Override
    public void run()
    {

        DialogInterface progressDialog = null;
        progressDialog.dismiss(); // even if initialized cannot update ui in a thread
    }
}.start();

score 0 · Answer 3 · answered Dec 17 '13 at 08:56

0

Just add Looper.prepare(); at the beggining of Your thread

new Thread()
    {
        @Override
        public void run()
        {
            Looper.prepare();
            DialogInterface progressDialog = null;
            progressDialog.dismiss();
        }
    }.start();

answered Dec 17 '13 at 08:56

Gooziec

2,736
1
13
18

@ElhamGdz remove the thread which does nothing. the asynctask is fine. Also you can't update ui from a thread. It should be done on ui thread. `DialogInterface progressDialog = null; progressDialog.dismiss();` will give NPE coz `progressDialog` is null – Raghunandan Dec 17 '13 at 09:02
The problem is that You call Async task in another Task. Try to add `Looper.prepare()` `readthread = new Thread(new Runnable() { public void run() { Looper.prepare(); ...};` – Gooziec Dec 17 '13 at 09:13

score 0 · Answer 4 · answered Dec 17 '13 at 09:12

0

You should do the UI call in the main UI thread. If you are doing in some other thread you will get this error. Since you are calling the progressDialog.dismiss from a new Thread() you are getting this error message.

answered Dec 17 '13 at 09:12

Sam

555
4
13

score 0 · Answer 5 · answered Apr 15 '15 at 10:16

0

new Thread()
    {
        @Override
        public void run()
        {
            Looper.prepare();

            //Your Dialog goes here

            Looper.loop(); 
        }
    }.start();

HtH.

answered Apr 15 '15 at 10:16

Naruto Uzumaki

2,019
18
37

Android : Can't create handler inside thread that has not called Looper.prepare()

5 Answers5