PHP ZipArchive non-English filenames return funky filenames within archive

Question

This code works properly to make the ZIP file with the wanted files, except the filenames in the archive, which are not in English (in this case they are Hebrew), have weird characters instead of the proper hebrew letters.

<?php
$filesfordown = $_POST['GEMin'];
    if(empty($filesfordown)) 
    {
        echo "No files were seleceted for download.";
    } 
    else 
    {
$zip_name = "RMW." . time() . ".zip";
$zip = new ZipArchive;
$zip->open($zip_name, ZipArchive::CREATE);
foreach ($filesfordown as $filefordown) {
  $zip->addFile($filefordown);
}
$zip->close(); }

header('Content-Type: application/zip');
header("Content-disposition: attachment; filename='$zip_name'");
header('Content-Length: ' . filesize($zip_name));
readfile($zip_name);

ob_flush;
?>

I did some searching around, it seems that iconv, setlocalte, or mb_convert_encoding might help, but whatever I tried didn't work.

Any ideas?

P.S. As a side question, is there a way to not keep directory structure in the zip?

ETA: An example of the $_post may be www.domain.com/path/שלום_01.mp3

Seems like this may be an old bug: https://bugs.php.net/bug.php?id=53948 — Daniel, Dec 16 '13 at 00:09

score 5 · Accepted Answer · edited Dec 29 '15 at 07:07

Yay! Fixed!

First the code, then an explanation:

<?php 
setlocale(LC_ALL, 'he_IL.UTF-8');
$filesfordown = $_POST['GEMin'];
    if(empty($filesfordown)) 
    {
        echo "לא נבחרו.. נסה שוב";
    } 
    else 
    {
$zip_name = "RMW" . time() . ".zip";
$zip = new ZipArchive;
$zip->open($zip_name, ZipArchive::CREATE);
echo "מכין את ההורדה...";
foreach ($filesfordown as $filefordown) {
  $zip->addFile($filefordown, iconv("UTF-8","CP862",basename($filefordown)));
}
$zip->close();

3 things needed to be changed.

Verify that the actual php file is UTF-8.
setlocale() needs to include the .UTF-8 at the end.
ZipArchive does not handle UTF-8 correctly. Must use CP. Hebrew was CP862. Therefore, use extra option $localname for addFile, and its basically iconv("UTF-8","CODE_PAGE_REF",$localname)

Two notes: 1) Choose the appropriate Code Page, could be Hebrew CP862, Western Europe CP850 or any other. 2) If your filenames differ in Code Page or uses characters from different Code Pages in a single filename, this method won't do it. — Jonas Äppelgran, Mar 24 '18 at 14:24

score 1 · Answer 2 · answered Apr 15 '16 at 22:02

1

It also works with: iconv("UTF-8", "CP852", $nameFile);

answered Apr 15 '16 at 22:02

Brandon Aguilar

389
6
14

PHP ZipArchive non-English filenames return funky filenames within archive

2 Answers2

Linked