46

In a Filter.doFilter method I made this call chain.doFilter.

What is doFilter doing inside a doFilter? Isn't it a recursive call?

DaveyDaveDave
  • 9,821
  • 11
  • 64
  • 77
giri
  • 26,773
  • 63
  • 143
  • 176

7 Answers7

61

Servlet Filters are an implementation of the Chain of responsibility design pattern.

All filters are chained (in the order of their definition in web.xml). The chain.doFilter() is proceeding to the next element in the chain. The last element of the chain is the target resource/servlet.

informatik01
  • 16,038
  • 10
  • 74
  • 104
Bozho
  • 588,226
  • 146
  • 1,060
  • 1,140
15

It is calling the doFilter method of the chain object, not itself, so no, it won't be recursive.

The name chain suggests that you have a sequence of filters, with each filter doing some processing and then passing on to the next in sequence, so each object has a chain member to point to the next filter in the sequence, which gets called after the filter has performed its own processing. The last in the sequence will then probably have null as the chain value, or it knows on its own that it is the last one in the sequence.

JaakkoK
  • 8,247
  • 2
  • 32
  • 50
3

Not having any code that you are talking about, I can only assume that you something like:

class Filter implements FilterAPI {
  private FilterAPI chain;
  FilterAPI(FilterAPI chain) { this.chain = chain; }
  @override void doFilter (Set setToFilter) {
    // do some filtering on setToFilter
    chain.doFilter(setToFilter);
  }
}

If that is the case, then you are not calling anything recursively, you are calling doFilter() on a different object. As mentioned on an another answer, this is the well known Chain of Responsibility design pattern.

Paul Wagland
  • 27,756
  • 10
  • 52
  • 74
2

Internally it invokes doFilter of the next filter in the filter chain, and, when chain is over, it invokes the target servlet.

axtavt
  • 239,438
  • 41
  • 511
  • 482
1

Causes the next filter in the chain to be invoked, or if the calling filter is the last filter in the chain, causes the resource at the end of the chain to be invoked.

1

By calling chain.doFilter you are handing the request/response to the next filter in your filter chain. If you do not call it then the next filter (probably defined in your web.xml) will not be executed.

If you just called doFilter, then yes you would have endless recursion and a stackoverflow. However, you are calling the doFilter method of the filterChain object, which instructs it to execute the next filter.

Kallin Nagelberg
  • 989
  • 8
  • 17
0

Yes, it is a recursive call to be precise. If you have a filter set to a folder as such,

/javax.faces.resource/*

then all the resources in this folder will be called recursively. So if you want to do something with the resources you will write

    @Override
  public void doFilter(ServletRequest request, ServletResponse response,
      FilterChain chain)
      throws IOException, ServletException {
    doSomething(request, response);
    chain.doFilter(request, response);
  }

The call to chain.doFilter(...) will process the current request/response and then call doFilter with the next resource until all the resources in url-pattern are processed by subsequent doFilter() calls.

Say you could have a ImagesFilter and a SessionFilter implemantation. For these Filter implementations you will define filter-mapping with URL-pattern.

<filter-mapping>
    <filter-name>SessionFilter</filter-name>
    <url-pattern>/*</url-pattern>
</filter-mapping>

All Resources in the path /* will end up being called by the doFilter(...) method in your filter implementation, but most interestingly the doFilter in the FilterChain will do the actual processing of the request/response. Hence if you don't call chain.doFilter(...) then your response can get broken.