1

I have a quick question about some demo code from the directshownet samples. Is the following:

// Set the video to stream to pictureBox1
int hr;
hr = this.videoWindow.put_Owner(this.pictureBox1.Handle);
DsError.ThrowExceptionForHR(hr);

Preferable to:

// Set the video to stream to pictureBox1        
DsError.ThrowExceptionForHR(this.videoWindow.put_Owner(this.pictureBox1.Handle));

for any reason? If so, why? Cheers

James
  • 53
  • 1
  • 6

1 Answers1

8

Suppose the code is incorrect and the method fails with an error HRESULT. You likely will be debugging this code in the near future. In that situation, what do you prefer? Having to debug into ThrowExceptionForHR to examine the HRESULT that was returned, or putting a watch on the local hr?

I know which I would prefer.

Suppose the hr is only an error code sometimes. What do you prefer, putting a breakpoint inside ThrowExceptionForHR, or putting a conditional breakpoint on the caller that only breaks if the value stored in hr is an error code?

Again, I know which I would prefer.

Design your code to be easy to debug. You'll thank yourself later.

Eric Lippert
  • 647,829
  • 179
  • 1,238
  • 2,067
  • 1
    That makes sense. I rarely use the IDE's debugger, so I hadn't considered it from that angle. – James Dec 13 '13 at 01:26