PHPMD - Avoid using Static Access to class - Using a constant?

Question

I am using PHP Mess Detector 1.5.0 and have a number of issues, that I do not believe are issues.

class FOO
{
    const NEW_LINE = "\n";
    const ADD = 1;
    const DELETE = 2;
    ...

    public function __construct($OptionOne = self::ADD)
    {
    }
}

In this code, I then use the constants similar to enumerations in C++ to work with options. Therefore, if I want to ADD something, I pass FOO::ADD in my code to the class, which is the same as 1.

I can test this class without an issue in PHPUnit, as I validate the constants, then I can pass the values and constants to functions.

I am not sure why PHPMD would complain about this, especially since it is a const value being referenced safely in PHP.

score 2 · Accepted Answer · answered May 25 '14 at 15:33

2

Because I use a lot of self:: for constants, change phpmd code to accept self:: and parent::.

In the program PHP/PMD/Rule/CleanCode/StaticAccess.php at line 36, change to:

if ($this->isReferenceInParameter($reference)
    || $reference->getImage() === 'self' 
    || $reference->getImage() === 'parent' 
    ) {
    continue;
}

answered May 25 '14 at 15:33

Alejandro Salamanca Mazuelo

1,173
15
21

I thought about that, but then I have to branch and maintain my own PHPMD, unless the tool can change, then it will be in the regular code and useful. – Steven Scott May 26 '14 at 01:52

PHPMD - Avoid using Static Access to class - Using a constant?

1 Answers1