Browsing an object's fields

Question

In Objective C, I have an object e.g. Person with a lot of fields firstName, lastName, phoneNumber, address, city... and so on. These fields types are NSString and any of these could be nil.

Now I want to concatenate my field values in another NSString :

Person *p = ...
NSMutableString *s = [[NSMutableString alloc] init];
for (NSString *field in @[p.firstName, p.lastName, p.phoneNumber,
                          p.adress, p.city, ....more fields...]) {
    if ([field length] > 0) {
        [s appendFormat:@"%@\n", field];
    }
}

Issue is that this code crash whenever one of the field is nil. I have the exception :

[__NSPlaceholderArray initWithObjects:count:]: attempt to insert nil object 
from objects[0]'

How could I handle simply the case of nil values within my for loop ?

Edited my question for clarity : there will be a lot of fields in the object (around 15) — Arnaud, Dec 09 '13 at 04:13
I saw my vote count go up and then down. Someone voted me down, and I lost 2 rep points.. Anyway I updated my answer to make it more complete. — Tom Pace, Dec 09 '13 at 04:34

BergQuester · Accepted Answer · 2013-12-09T06:40:19.040

I agree with @TomPace's post, for this small number I would do a simple if/else.

However, there may be times you do need to loop through a list of fields.

It's a bad idea to blindly pull the values into an array as you could be trying inserting nil values into the array. In this case, it would be better to place the field names into a key array as strings and loop through the list using valueForKey: to access the values. I would possibly store the keys list somewhere else where it can be used again.

Person *p = ...
NSMutableString *s = [[NSMutableString alloc] init];

NSArray *keys = @[@"firstName", @"lastName", @"phoneNumber", @"adress", @"city"];

for (NSString *key in keys) 
{
    NSString *value = [p valueForKey:key];
    if ([value length] > 0) {
        [s appendFormat:@"%@\n", value];
    }
}

Tom Pace · Answer 2 · 2013-12-09T04:29:34.347

For a selection of fields this small, don't use a for loop.

You may be saving a bit of code by attempting the for-loop structure, but it's really not the way to go if you're building the NSArray with only a few fields, and especially because you can't put nil items in it.

A better way to go is:

Person *p = ...
NSMutableString *s = [[NSMutableString alloc] init];
if ([p.firstName length] > 0)   [s appendFormat:@"%@\n", p.firstName];
if ([p.lastName length] > 0)    [s appendFormat:@"%@\n", p.lastName];
if ([p.phoneNumber length] > 0) [s appendFormat:@"%@\n", p.phoneNumber];
if ([p.adress length] > 0)      [s appendFormat:@"%@\n", p.adress];
if ([p.city length] > 0)        [s appendFormat:@"%@\n", p.city];

Edit, after original Question was updated with large amount of fields. Like @BergQuester said, an approach to support a larger, arbitrary set of fields is using KVO-style inspection.

NSArray *fieldNames = @[@"firstName", @"lastName", @"phoneNumber", ....more fields...];
NSString *field;
for (NSString *fieldName in fieldNames) {
    field = [p valueForKey:fieldName];
    if ([field length] > 0 ) {
        [s appendFormat: @"%@\n", field];
    }
}

The `> 0` is redundant (not wrong, just pointing out another stylistic option.) — Aaron Brager, Dec 09 '13 at 06:11
@AaronBrager thanks, yes you're right. I guess I was just following the style of the original question. I prefer the omission myself. — Tom Pace, Dec 09 '13 at 07:13

score 0 · Answer 3 · answered Dec 09 '13 at 04:27

Person *person = [[Person alloc] init];
person.firstName = nil;
person.lastName = @"lastName";

NSMutableString *s = [[NSMutableString alloc] init];
[s appendFormat:@"%@\n", person.firstName == nil?@"":person.firstName];
[s appendFormat:@"%@\n",  person.lastName == nil?@"":person.lastName];

Ramaraj T · Answer 4 · 2013-12-09T10:04:09.720

0

You can override the getters of the class Person.

    @implementation Person

    - (NSString *)firstName{
        if (_firseName == nil)
             _firstName = @"";
        return _firstName;
    }
///....Other setters    

    @end

Like this you can define all your setters here.

edited Dec 09 '13 at 10:04

answered Dec 09 '13 at 05:09

Ramaraj T

5,184
4
35
68

Those are getters, not setters. – Aaron Brager Dec 09 '13 at 06:08
Also, this solution wastes memory and could have negative side effects. – Aaron Brager Dec 09 '13 at 06:13

Eugene P · Answer 5 · 2013-12-09T06:22:30.103

0

Try to create NSMutableString category

#import "NSMutableString+checkForNilObject.h"

@implementation NSMutableString (checkForNilObject)


-(void) appendNotNillObject:(NSString *) string
{
    if(string)
    {
       [self appendString:string];
    }
}
@end

edited Dec 09 '13 at 06:22

answered Dec 09 '13 at 05:27

Eugene P

554
4
19

Browsing an object's fields

5 Answers5