Confusion about Generic Classes and ArrayLists

Question

This is a group of classes that I made for context to the question

Aquarium class:

package test;

import java.util.ArrayList;

public class Aquarium {

// the aquarium is composed of fish tanks

ArrayList<Object> aquarium;

public Aquarium(){

    aquarium = new ArrayList<Object>();

}

public <T> void addFishToTank(int index, T fish){

    FishTank<T> tank = (FishTank<T>) aquarium.get(index);
    tank.addFish(fish);

}


public ArrayList<Object> getAquarium(){

    return aquarium;

}

public String toString(){

    String holder = "";

    int i = 0;

    for (Object tank : aquarium){

        holder += "Tank " + i + ":\n"; 

        holder += tank.toString();

        i ++;

    }

    return holder;

}

public static void main(String[] args){


    Aquarium seaWorld = new Aquarium();

    seaWorld.getAquarium().add(new FishTank<Salmon>());

    seaWorld.addFishToTank(0, new Salmon());
    seaWorld.addFishToTank(0, new Grouper());

    System.out.println(seaWorld.toString());

}

}

FishTank class:

package test;

import java.util.ArrayList;

public class FishTank<T>{

// inside each fish tank there is a group of fish

ArrayList<T> fishGroup = new ArrayList<T>();

public void addFish(T element){

    fishGroup.add(element);     

}

public String toString(){

    String holder = "";

    for (T fish: fishGroup){

        holder += fish.toString() + "\n";

    }

    return holder;
}


}

Salmon class:

package test;

public class Salmon {

public String toString(){

    return "This is a salmon";
}

}

Grouper class:

package test;

public class Grouper {

public String toString(){

    return "This is a grouper";
}

}

All the code compiles fine and the output of Aquarium ends up being

Tank 0:
This is a salmon
This is a grouper

How can this be possible? When I added the tank to the aquarium

seaWorld.getAquarium().add(new FishTank<Salmon>());

it was specified that it was a FishTank that can only hold Salmon objects. First, I added a Salmon object

seaWorld.addFishToTank(0, new Salmon());

and that would be fine since the fish tank at index 0 of the aquarium is a fish tank that holds Salmon objects. But when I add a Grouper object to the Salmon tank at index 0

seaWorld.addFishToTank(0, new Grouper());

it still adds the Grouper to the tank. Shouldn't an exception be thrown during run time? Then, how can I enforce so that only Salmon objects be added to the Salmon tank?

related: http://stackoverflow.com/questions/6139325/heterogeneous-container-to-store-genericly-typed-objects-in-java — Judge Mental, Dec 06 '13 at 20:33

Judge Mental · Accepted Answer · 2016-03-18T21:47:35.683

4

Generics are only for compile-time type safety. If you want an aquarium that has individually-typed tanks whose underlying fish types are not known at compile time, you are out of luck in Java. And to make matters worse, because the generic types are all erased during compilation, what you're left with is Object everywhere.

The reason there is no class cast exception is because at runtime it is just a FishTank (the raw type) at every array index, into which you can freely mix fish (or land animals, or psychological constructs).

One approach to solving this type of problem is to make your FishTank aware of its membership at runtime by including a Class< T > field. The tank can then impose run-time checks during addFish(), although the strictness of said checks is limited (for example, if your fish is itself a generic container, you'll still be able to mix containers in the same tank; getClass() returns an "erased" class object).

edited Mar 18 '16 at 21:47

answered Dec 06 '13 at 20:23

Judge Mental

5,209
17
22

2

Apart from using `Class`, you can ease yourself for the pain of checking if the incoming object belongs to the valid class by using [`Collections#checkedList`](http://docs.oracle.com/javase/7/docs/api/java/util/Collections.html#checkedList%28java.util.List,%20java.lang.Class%29) instead of having a plain `ArrayList` as attribute. – Luiggi Mendoza Dec 06 '13 at 20:31
@LuiggiMendoza Where would you incorporate the creation of the checked list? in fish tank? I tried List fishGroup = Collections.checkedList(new ArrayList(), T.class); but this is not allowed. – Lucas Alanis Dec 06 '13 at 21:06
1

@LanceFerd yes. From your current code, I would redefine `ArrayList fishGroup = new ArrayList();` as `List fishGroup;` and initialize it in the class constructor as `public FishTank(Class clazz) { fishGroup = Collections.checkedList(new ArrayList(), clazz); }`. – Luiggi Mendoza Dec 06 '13 at 21:10

score 2 · Answer 2 · answered Dec 06 '13 at 20:23

How can this be possible?

Because generic type parameters are erased at runtime, and are not checked on adding elements to a collection. They are only checked upon performing a cast. (But not a cast to T, because T is erased, so becomes just Object, so such a cast would check nothing.)

Confusion about Generic Classes and ArrayLists

2 Answers2