Is there better way to extract key/values from string like this

Question

I have following string:

OK:<IDP RESULT="0" MESSAGE="some message" ID="oaisjd98asdh339wnf" MSGTYPE="Done"/>

I use this method to parse and get result:

public string MethodName(string capt)
{
    var receivedData = capt.Split(' ').ToArray();
    string _receivedReultValue = "";
    foreach (string s in receivedData)
    {
        if (s.Contains('='))
        {
            string[] res = s.Split('=').ToArray();
            if (res[0].ToUpper() == "RESULT")
            {
                string resValue = res[1];
                resValue = resValue.Replace("\\", " ");
                _receivedReultValue = resValue.Replace("\"", " ");
            }
        }
    }

    return _receivedReultValue.Trim();
}

Is there better way to parse string like this to extract data?

You don't need to call `ToArray()` in `capt.Split('something').ToArray();` `Split` already returns an array. — Ondrej Janacek, Dec 05 '13 at 13:36

Mike Perrenoud · Accepted Answer · 2013-12-05T14:14:24.033

2

What you have isn't all that bad. But, because it's XML you could do this:

class Program
{
    static void Main(string[] args)
    {
        var capt = "OK:<IDP RESULT=\"0\" MESSAGE=\"some message\" ID=\"oaisjd98asdh339wnf\" MSGTYPE=\"Done\"/>";
        var stream = new MemoryStream(Encoding.Default.GetBytes(capt.Substring(capt.IndexOf("<"))));
        var kvpList = XDocument.Load(XmlReader.Create(stream))
                   .Elements().First()
                   .Attributes()
                   .Select(a => new
                   {
                       Attr = a.Name.LocalName,
                       Val = a.Value
                   });
    }
}

That would give you an IEnumerable of that anonymous type.

edited Dec 05 '13 at 14:14

answered Dec 05 '13 at 13:41

Mike Perrenoud

66,820
29
157
232

Using this I get "Illegal characters in path." – 1110 Dec 05 '13 at 13:49
@1110, hmm. That was the purpose of the `Substring`. I wanted it to start reading at the `<`. – Mike Perrenoud Dec 05 '13 at 13:50
@1110, please see my edit. I needed to turn the `string` into a `stream`. My apologies. – Mike Perrenoud Dec 05 '13 at 13:57
XDocument.Load(stream) - invalid argument on this line – 1110 Dec 05 '13 at 13:58
@1110, did you build the `stream`, like I did in the example? That's a fully functional console application there. – Mike Perrenoud Dec 05 '13 at 14:03
I use .NET 3.5 maybe that is the problem – 1110 Dec 05 '13 at 14:05
@1110, yes it is. Let me modify my solution. – Mike Perrenoud Dec 05 '13 at 14:07
I already find it based on answer above `var ms = new MemoryStream(Encoding.Default.GetBytes(capt.Substring(capt.IndexOf("<")))); var rdr = new XmlTextReader(ms); var kvpList = XDocument.Load(rdr) .Elements().First() .Attributes() .Select(a => new { Attr = a.Name.LocalName, Val = a.Value });` – 1110 Dec 05 '13 at 14:10
@1110, please see my edit. It's more straight forward than that I think. – Mike Perrenoud Dec 05 '13 at 14:14

Alexandre Machado · Answer 2 · 2013-12-05T14:04:18.273

You can use XDocument, assuming that you will remove the "OK:" at the beginning you can do it like this:

    static void Main(string[] args)
    {
        var str = "<IDP RESULT=\"0\" MESSAGE=\"some message\" ID=\"oaisjd98asdh339wnf\" MSGTYPE=\"Done\"/>";
        var doc = XDocument.Parse(str);
        var element = doc.Element("IDP");
        Console.WriteLine("RESULT: {0}", element.Attribute("RESULT").Value);
        Console.WriteLine("MESSAGE: {0}", element.Attribute("MESSAGE").Value);
        Console.WriteLine("ID: {0}", element.Attribute("ID").Value);
        Console.WriteLine("MSGTYPE: {0}", element.Attribute("MSGTYPE").Value);

        Console.ReadKey();
    }

EDIT: I tested the code above on .NET 4.5. For 3.5 I had to change it a bit

    static void Main(string[] args)
    {
        const string str = "<IDP RESULT=\"0\" MESSAGE=\"some message\" ID=\"oaisjd98asdh339wnf\" MSGTYPE=\"Done\"/>";
        var ms = new MemoryStream(Encoding.ASCII.GetBytes(str));
        var rdr = new XmlTextReader(ms);
        var doc = XDocument.Load(rdr);
        var element = doc.Element("IDP");
        Console.WriteLine("RESULT: {0}", element.Attribute("RESULT").Value);
        Console.WriteLine("MESSAGE: {0}", element.Attribute("MESSAGE").Value);
        Console.WriteLine("ID: {0}", element.Attribute("ID").Value);
        Console.WriteLine("MSGTYPE: {0}", element.Attribute("MSGTYPE").Value);

        Console.ReadKey();
    }

ops, this works with the framework 4.5. I'm editing my answer for older framework versions. — Alexandre Machado, Dec 05 '13 at 14:02

score 0 · Answer 3 · answered Dec 05 '13 at 13:40

Sure. It looks like XML, you may use normal XML methods for this. if you remove "OK" and add

<?xml version="1.0" ?>
<IDP RESULT="0" MESSAGE="some message" ID="oaisjd98asdh339wnf" MSGTYPE="Done"/>

this can be parsed by any XML decoder. Try xmllint to check it out.

Konrad Kokosa · Answer 4 · 2013-12-05T13:49:35.627

You can Regex to obtain all key/value pairs:

string str = @"OK:<IDP RESULT=""0"" MESSAGE=""some message"" ID=""oaisjd98asdh339wnf"" MSGTYPE=""Done""/>";
var matches = Regex.Matches(str, @"(?<Key>\w+)=""(?<Value>[^""]+)""");

then you can access RESULT attribute:

var match = matches.OfType<Match>()
                   .FirstOrDefault(match => match.Groups["Key"].Value == "RESULT");
if (match != null)
{
    result = match.Groups["Value"].Value;
}

BRAHIM Kamel · Answer 5 · 2013-12-05T16:01:40.030

0

try this is too simple

 string xml = @"OK:<IDP RESULT=""0"" MESSAGE=""some message"" ID=""oaisjd98asdh339wnf"" MSGTYPE=""Done""/>";


        XElement xElement = XElement.Parse(new string(xml.Skip(3).ToArray()));
        //for example message 
          var message  = xElement.Attribute("MESSAGE").Value;

edited Dec 05 '13 at 16:01

answered Dec 05 '13 at 14:03

BRAHIM Kamel

13,492
1
36
47

Is there better way to extract key/values from string like this

5 Answers5