While using 2 different HashMaps, i'm able to create a keySet with the first but not the second

Question

I'm working with 2 different HashMaps in a class, and when I call the keySet() method with the first (the getExitString() method), it works fine, but when I call it with the second (the getLockedDoors() method), I get the "cannot find symbol - method keySet()" error. How can I fix this? Thanks! The relevant code is below.

import java.util.HashMap;
import java.util.Set;

public class Room 
{
private HashMap<String, Room> exits;    
private HashMap<String, LockedDoor> lockedDoors;

public String getExitString() {
    String exitReturn = "";
    Set<String> exitSet = exits.keySet();
    for (String eachExit : exitSet) {
        exitReturn = exitReturn + eachExit + " ";
    }
    return exitReturn;
}

public String getLockedDoorString() {
    String lockedDoors = "";
    Set<String> doorSet = lockedDoors.keySet();
    for (String door : doorSet) {
        lockedDoors = lockedDoors + door + " ";
    }
    return lockedDoors;
}

score 4 · Accepted Answer · edited Nov 29 '13 at 06:23

4

At the failing line, lockdoors resolves to a String and not a HashSet expression.

This is because the local variable shadows the member variable with the same name.

String lockedDoors = "";                     // shadowed here
Set<String> doorSet = lockedDoors.keySet();  // and String.keySet() is bogus

Solution: You can either use a different name for your local variable (recommended, IMO) or use the this keyword to reference the instance level variable (a concept often required). Here's a sample.

String lockedDoors = "";
Set<String> doorSet = this.lockedDoors.keySet();

edited Nov 29 '13 at 06:23

javatarz

1,174
16
30

answered Nov 29 '13 at 06:11

user2864740

60,010
15
145
220

+1 for a good explanation. Next time provide a solution too. I've edited the post to do so (waiting to be peer reviewed) – javatarz Nov 29 '13 at 06:14
@JAnderton Whoops, I think I accidentally cancelled your edit :( That is good advice though and I added some solutions. – user2864740 Nov 29 '13 at 06:14
Added the solution again.. :) – javatarz Nov 29 '13 at 06:17
Haha, edit tag. I'm gonna walk away and see where it ends up xD – user2864740 Nov 29 '13 at 06:18
thanks for the help! didn't realize i'd named them the same thing. – Adam Berman Nov 29 '13 at 15:09

score 1 · Answer 2 · answered Nov 29 '13 at 06:12

1

Your local variable name and the name for the HashMap is same hence giving error

answered Nov 29 '13 at 06:12

Shubham Kankaria

145
9

score 0 · Answer 3 · answered Nov 29 '13 at 06:13

0

String lockedDoors = "";

lockedDoors is String object, which has same name as your HashMap lockedDoors.

And String class does not have the method keySet :)

answered Nov 29 '13 at 06:13

user1933888

2,897
3
27
36

score 0 · Answer 4 · answered Nov 29 '13 at 06:55

String lockedDoors = "";
Set<String> doorSet = lockedDoors.keySet();

The main problem with your code is above two lines because "Already you have declared lockedDoors as a hashmap object and you have declared lockedDoors as string object in method getLockedDoorString()", In this case lockedDoors variable always reference to the local string lockedDoors object. That's why it's throwing error. please use different name or declare your variable on top.

While using 2 different HashMaps, i'm able to create a keySet with the first but not the second

4 Answers4