Why does this code give me an infinite loop?

Question

When I enter in a correct value (an integer) it is good. But when I enter in a character, I get an infinite loop. I've looked at every side of this code and could not find a problem with it. Why is this happening? I'm using g++ 4.7 on Windows.

#include <iostream>
#include <limits>

int main()
{
    int n;
    while (!(std::cin >> n))
    {
        std::cout << "Please try again.\n";
        std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');
        std::cin.clear();
    }
}

Input: x
Output:

enter image description here

is there an unprintable character like CR coming along with the input when you type or does `cin` grab one character? — bright-star, Nov 27 '13 at 22:39
@qwrrty Well, `scanf` is marginally faster than `cin >>` (not sure why, it has to parse the format string), so if the question is "performance!1!!11elevenone", it may be the answer. — Joker_vD, Nov 28 '13 at 06:26

score 6 · Accepted Answer · answered Nov 27 '13 at 22:46

6

It's because your recover operations are in the wrong order. First clear the error then clear the buffer.

    std::cin.clear();
    std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');

answered Nov 27 '13 at 22:46

john

85,011
4
57
81

Thanks. I couldn't even tell! :) – template boy Nov 27 '13 at 22:51
1

The point is that because the stream is in an error state `ignore` will also fail unless you clear the error first. – john Nov 27 '13 at 22:52

score 4 · Answer 2 · answered Nov 27 '13 at 22:46

4

You have to clear the error state first, and then ignore the unparsable buffer content. Otherwise, ignore will do nothing on a stream that's not in a good state.

You will separately need to deal with reaching the end of the stream.

answered Nov 27 '13 at 22:46

Kerrek SB

464,522
92
875
1,084

Why does this code give me an infinite loop?

2 Answers2