DatePickerDialog always opens the current date

Question

I am having trouble with a DatePickerDialog, everytime I open it shows the current date not the date I set previously.

Here's my code:

    final Calendar c = Calendar.getInstance();
    final int mYear = c.get(Calendar.YEAR);
    final int mMonth = c.get(Calendar.MONTH);
    final int mDay = c.get(Calendar.DAY_OF_MONTH);

    DatePickerDialog.OnDateSetListener datePickerListener = new DatePickerDialog.OnDateSetListener() {

        // when dialog box is closed, below method will be called.
        public void onDateSet(DatePicker view, int selectedYear,
                int selectedMonth, int selectedDay) {
            editText.setText(selectedYear + "年"
                    + selectedMonth + 1 + "月"
                    + selectedDay + "日");
        }
    };

    DatePickerDialog datePickerDialog = new DatePickerDialog(SampleActivity.this,
            datePickerListener, mYear, mMonth, mDay);

    datePickerDialog.setButton(DialogInterface.BUTTON_NEGATIVE, "Cancel",
            new DialogInterface.OnClickListener() {
                public void onClick(DialogInterface dialog, int which) {
                    if (which == DialogInterface.BUTTON_NEGATIVE) {
                        dialog.cancel();
                    }
                }
            });

    datePickerDialog.setCancelable(false);
    datePickerDialog.show();

What did I miss here?

`Calendar.getInstance()` will return today's date and time with default timezone. — Andrew T., Nov 22 '13 at 05:22
Thanks, it has been answered. But my question is how to give the `DatePickerDialog` I previously selected value, the next time I open it. — Compaq LE2202x, Nov 22 '13 at 06:19

score 2 · Accepted Answer · edited Jan 30 '15 at 04:27

This may help you:

public class TestActivity extends Activity {
private int mYear;
private int mMonth;
private int mDay;

private void showDialog() {
    if (mYear == 0 || mMonth == 0 || mDay == 0) {
        final Calendar c = Calendar.getInstance();
        mYear = c.get(Calendar.YEAR);
        mMonth = c.get(Calendar.MONTH);
        mDay = c.get(Calendar.DAY_OF_MONTH);
    }

    DatePickerDialog.OnDateSetListener datePickerListener = new DatePickerDialog.OnDateSetListener() {

        // when dialog box is closed, below method will be called.
        public void onDateSet(DatePicker view, int selectedYear,
                int selectedMonth, int selectedDay) {
            editText.setText(selectedYear + "年" + selectedMonth + 1 + "月"
                    + selectedDay + "日");
            mYear = selectedYear;
            mMonth = selectedMonth;
            mDay = selectedDay;
        }
    };

    DatePickerDialog datePickerDialog = new DatePickerDialog(
            SampleActivity.this, datePickerListener, mYear, mMonth, mDay);

    datePickerDialog.setButton(DialogInterface.BUTTON_NEGATIVE, "Cancel",
            new DialogInterface.OnClickListener() {
                public void onClick(DialogInterface dialog, int which) {
                    if (which == DialogInterface.BUTTON_NEGATIVE) {
                        dialog.cancel();
                    }
                }
            });

    datePickerDialog.setCancelable(false);
    datePickerDialog.show();
}
}

Below sample code will give complete solution:

public class SecondActivity extends FragmentActivity implements OnClickListener{

    private static final String TAG = SecondActivity.class.getName();
    private int year;
    private int month;
    private int day;
    private boolean isCancelled;

    private EditText editText;

    @Override
    protected void onCreate(Bundle arg0) {
        super.onCreate(arg0);
        setContentView(R.layout.second_activity_layout);
        editText = (EditText) findViewById(R.id.editText);
    }

    public void onButtonClick(View view) {
        onClick(view);
    }

    @Override
    public void onClick(View v) {
        if(year == 0) {
            Calendar calendar = Calendar.getInstance();
            day = calendar.get(Calendar.DAY_OF_MONTH);
            month = calendar.get(Calendar.MONTH);
            year = calendar.get(Calendar.YEAR);
        }
        OnDateSetListener callBack = new OnDateSetListener() {

            @Override
            public void onDateSet(DatePicker view, int year, int monthOfYear,
                    int dayOfMonth) {
                if(isCancelled) {
                    Log.i(TAG, "Cancelled");
                    isCancelled = false;
                } else {
                    editText.setText("Date selected");
                    month = monthOfYear;
                    day = dayOfMonth;
                    SecondActivity.this.year = year;
                }
            }
        };
        DatePickerDialog dialog = new DatePickerDialog(this, callBack, year, month, day);
        dialog.setButton(DialogInterface.BUTTON_NEGATIVE, "Cancel", new DialogInterface.OnClickListener() {

            @Override
            public void onClick(DialogInterface dialog, int which) {
                if(which == DialogInterface.BUTTON_NEGATIVE) {
                Log.i(TAG, "Cancel");
                isCancelled = true;
                dialog.dismiss();}
            }
        });
        dialog.setCancelable(false);
        dialog.show();
    }
}

There's a problem, if I click Cancel the highlighted date is still selected because of the `datePickerListener` where I commented `// when dialog box is closed, below method will be called.` How do I `setText` if I click `OK` only? — Compaq LE2202x, Nov 22 '13 at 06:45
maintain one boolean variable and when user clicks on cancel, make it true and validate that variable value in onDateSet — Gopal Gopi, Nov 22 '13 at 06:54
Basically what I did was to set also a `DialogInterface.BUTTON_POSITIVE` and made a flag for it with the same concept as you. So yeah, thanks again! — Compaq LE2202x, Nov 22 '13 at 07:28

score 0 · Answer 2 · answered Nov 22 '13 at 05:29

Instead of this ,,,

final Calendar c = Calendar.getInstance();
    final int mYear = c.get(Calendar.YEAR);
    final int mMonth = c.get(Calendar.MONTH);
    final int mDay = c.get(Calendar.DAY_OF_MONTH);

use following

    String returnedDate = the date which u already set ..



    Date dateToEditApp = new Date();
                SimpleDateFormat newFormatDate = new SimpleDateFormat(
                        "dd MMM yyyy");
                try {
                    dateToEditApp = newFormatDate.parse(returnedDate);
                } catch (ParseException e) {

                    e.printStackTrace();
                    LoggerFile.logwriter("high",TAG + " ParseException "    + e.getMessage());
                }

                Calendar calDate = Calendar.getInstance();

                calDate.setTime(dateToEditApp);

                mYear = calDate.get(Calendar.YEAR);
                mMonth = calDate.get(Calendar.MONTH);
                mDay = calDate.get(Cale

ndar.DAY_OF_MONTH);

score 0 · Answer 3 · answered Nov 22 '13 at 06:01

Just save date,month and year values into VARIABLES while SETTING the date and in next set use ONPREPAREDIALOG function to set previously set date in your satepicker dialog - such as -

private int thisYear, thisMonth, thisday;

private DatePickerDialog.OnDateSetListener dateSetListener = new DatePickerDialog.OnDateSetListener() {
    public void onDateSet(DatePicker view, int year, int monthOfYear, int dayOfMonth) {
           thisYear = year;
           thisMonth = monthOfYear;
           thisday = dayOfMonth;
    }
};

@Override
protected void onPrepareDialog(int id, Dialog dialog) {
          ((DatePickerDialog) dialog).updateDate(thisYear , thisMonth , thisday);
}

DatePickerDialog always opens the current date

3 Answers3

Linked