algorithm of make_heap() function in

Question

I was just experimenting with make_heap() function in C++. Following is the code where I am keeping a track of the elements that are being compared every time the bool predicate() is called, by printing them.

#include <iostream>
#include <algorithm>
using namespace std;

// bool predicate function to make a min heap
bool predicate(int a, int b){
    cout << a << "  " << b << endl;
    if(a >= b){ return 1; }
    return 0;
}


int main(){
    int arr[] = {3,2,1,-1,-2};
    make_heap(arr, arr+5, predicate);
    return 0;
}

The output that I am getting is :
-2 -1
-2 2
1 -2
2 -1
-1 3

But I was expecting the following output, keeping in view the standard algorithm :
-2 -1
-2 2
1 -2
3 -2
2 -1
-1 3

any help ?

You have the template source for *your* implementation's `make_heap`. is there something preventing you from stepping through it? — WhozCraig, Nov 15 '13 at 09:42
The C++ implemented `make_heap` made the heap by minimum comparisons, do you want it do more comparisons? — masoud, Nov 15 '13 at 09:51

score 1 · Answer 1 · answered Nov 15 '13 at 10:00

I would not say there is an algorithm standardized enough so that you expect specific set of comparisons to be performed. What is standardized is the complexity of the algorithm and as long as the number of comparisons is of linear order you should be good to go. Moreover it seems stl performs better than you in term of number of comparisons so you should not be worried.

As suggested in the comments you can always read the code of the implementation of std::make_heap that your compiler uses but there is no guarantee the same implementation will be used in all implementations of stl.

algorithm of make_heap() function in

1 Answers1