HttpModule - need to redirect the user to a specific page when OnError hits

Question

This is my first time working with HttpModules. I need to create a "drag and drop" sort of solution into existing ASP.NET applications that will provide common error handling by redirecting the users to a new "ErrorFeedback.aspx" page. So, when an app encounters an exception, the user will be redirected to ErrorFeedback.aspx where they'll be able to provide feedback surrounding the error, if they need to. We have around 300 web apps currently so the "drag and drop" solution that seems most promising is an HttpModule. This ErrorFeedback page will be a new page that will also be added to the solution as well. Eventually these components (the DLL and the custom web page) will wind up in a Nuget package, but for the time being it will need to be manually copied/pasted into the existing solution.

I've heard that doing a redirect within the module is bad practice. What's the best practice for redirecting a user to a specific page whenever OnError in the HttpModule is encountered?

Saeed Neamati · Answer 1 · 2013-11-14T20:26:18.143

1

You can use custom error pages in Web.config, instead of HttpModule. But if you really need to redirect, it's better to use RewitePath method.

And here are some notes in general:

When you use URL rewriting, you should be careful about SEO. Because your original URL would count in SERPs.
ASP.NET routing is also a good mechanism and alternative to what you're trying to do
Why do you say that redirection is bad in HttpModule? Any specific reason?

edited Nov 14 '13 at 20:26

answered Nov 14 '13 at 20:20

Saeed Neamati

35,341
41
136
188

I just *heard* that it was bad. I didn't know if it really was or not. And also, this is an intranet app so SEO is a non-issue. Thanks for the info though! – Mike Marks Nov 14 '13 at 20:27

score 1 · Accepted Answer · edited Feb 24 '16 at 15:15

If you only need to redirect you would be best of using web.config custom error pages. But if you also want to do some more things, like logging for example than you need to use HttpModule, something like this:

public class ErrorManagementModule : IHttpModule
{
    public void Dispose() { }

    public void Init(HttpApplication context)
    {
        //handle context exceptions
        context.Error += (sender, e) => HandleError();
        //handle page exceptions
        context.PostMapRequestHandler += (sender, e) => 
            {
                Page page = HttpContext.Current.Handler as Page;
                if (page != null)
                    page.Error += (_sender, _e) => HandleError();
            };
    }

    private void HandleError()
    {
        Exception ex = HttpContext.Current.Server.GetLastError();
        if (ex == null) return;

        LogException(ex);

        HttpException httpEx = ex as HttpException;
        if (httpEx != null && httpEx.GetHttpCode() == 500)
        {
            HttpContext.Current.Response.Redirect("/PrettyErrorPage.aspx", true);
        }
    }
}

Will the web.config custom error pages catch non-HTTP errors, such as application exceptions? I didn't think it would, but I might be wrong? — Mike Marks, Nov 14 '13 at 22:16
Well most of the unhandled exceptions will translate to HTTP 500 and if you have the redirect for 500 in your web.config it will redirect. — Davor Zlotrg, Nov 14 '13 at 22:17

HttpModule - need to redirect the user to a specific page when OnError hits

2 Answers2