How to update a row depending on a condition

Question

I try to update a row in my database. i receive no error but the update does not happend

$sql = "UPDATE calendar_events 
        SET event_title='".$_POST["naam"]."' 
        WHERE id ='($event_id)'";

problem is by variable $event_id. If i place a nummber in place of $event_id ( WHERE id =6) then it is ok and i have my update but any he do not accept any variable I did change a lot of things. The type of variabls id and $event_id are the same. De value of the id and $event_id are de same . i did try with $event_id, and '".$event_id."'. every thing is ok and no erroror from database bat the update do not happen. can someone help me thanks

And of course please filter your naam before entering it into the sql string! — ToBe, Nov 14 '13 at 16:28
Try printing the sql onscreen, and if the sql is correct, execute it on the Database you are working on, to see if the query is correct for the database. — Juan Garcia, Nov 14 '13 at 16:29
Use `WHERE id = '$event_id' ";` instead. Parentheses are mostly used when there is more than one value. Plus, using `'".$_POST["naam"]."'` is not considered a safe calling method. — Funk Forty Niner, Nov 14 '13 at 16:30
I also noticed in [your other question](http://stackoverflow.com/questions/19957009/update-the-single-row-in-php-row-with-php) that you are using `MySQL_` - I strongly suggest that you move over to `MySQLi_` or PDO. Mostly for security reasons. Your site/DB stands at being hacked if you continue using this method. — Funk Forty Niner, Nov 14 '13 at 16:37

score 0 · Answer 1 · answered Nov 14 '13 at 16:27

0

Try with

$sql = "UPDATE calendar_events 
        SET event_title='".$_POST["naam"]."' 
         WHERE id ='$event_id'";

Otherwise, you are comparing it with (1), (2) or whatever number it has, but with parenthesis.

UPDATE: and, of course, SANITIZE your $_POST variables!!!

answered Nov 14 '13 at 16:27

opalenzuela

3,139
21
41

I did try but no resault. – chehr Nov 14 '13 at 16:43
my query say dat it is happend if (!mysql_query($sql)) is true – chehr Nov 14 '13 at 16:44
This has something to do with the other question (OP) http://stackoverflow.com/questions/19957009/update-the-single-row-in-php-row-with-php I'm sure. – Funk Forty Niner Nov 14 '13 at 16:45
I am wondering if i use just a number in my condition then it is ok – chehr Nov 14 '13 at 16:47
Can you provide an example query? – opalenzuela Nov 14 '13 at 16:50
$sql = "UPDATE calendar_events SET event_title='abc' WHERE id='$event_id'"; if (!mysql_query($sql)) { // voer SQL code uit echo "not ok"; return; } echo "OK"; } else { – chehr Nov 14 '13 at 16:53
if $event_id has a valid value, the query is OK, so it should work. Otherwise, you might have: permission problems, no equivalent $event_id values, misconfiguration of your PHP... – opalenzuela Nov 14 '13 at 16:57

How to update a row depending on a condition

1 Answers1