RSpec update_attributes expectation failing, even though update works

Question

I'm using what is largely a scaffold generated RSpec spec, which is failing but shouldn't be. Here is the spec:

describe "PUT update" do
    describe "with valid params" do
      it "updates the requested invoice" do


      invoice = Invoice.create!

       Invoice.any_instance.should_receive(:update_attributes).with({"number" => "MyString"  })
    put :update, {:id => invoice.id, :invoice => { "number" => "MyString" }}
  end

When the spec is run, one Invoice is created in the db, and is updated appropriately. However, I get this message and a fail:

RSpec::Mocks::MockExpectationError: (#<Mocha::ClassMethods::AnyInstance:0x653a9a8>).update_attributes({"number"=>"MyString"})
expected: 1 time with arguments: ({"number"=>"MyString"})
received: 0 times with arguments: ({"number"=>"MyString"})

Why is this failing?

Assuming you _want_ to be using Mocha with RSpec, did you follow the insructions at https://relishapp.com/rspec/rspec-core/v/2-14/docs/mock-framework-integration/mock-with-mocha? — Peter Alfvin, Nov 14 '13 at 03:25
Actually, the installed Mocha gem is a holdover from when I was first setting up the project and hadn't decided to use RSpec (as opposed to minutest which is what I've used in the past). RSpec is not configured to use mocha. — Jeffrey Alan Lee, Nov 16 '13 at 03:36

score 1 · Accepted Answer · edited May 23 '17 at 12:07

1

At the risk of stating the obvious, since your getting a Mocha error, it seems to me you need to either disable Mocha or configure it for use with RSpec.

You can disable a gem by removing it from Gemfile and re-executing bundle install. Or you can add a 'require: false` argument when specifying the gem so that it doesn't autoload, per Bundler: What does :require => false in a Gemfile mean?

Instructions for configuring Mocha to work with RSpec are in https://relishapp.com/rspec/rspec-core/v/2-14/docs/mock-framework-integration/mock-with-mocha

edited May 23 '17 at 12:07

Community

1
1

answered Nov 16 '13 at 04:06

Peter Alfvin

28,599
8
68
106

The obvious is frequently the answer. That was, in fact, the problem. I should have picked up on that. I'm unclear as to why Mocha was involving itself as RSpec was supposed to use it's own mocking facilities. – Jeffrey Alan Lee Nov 17 '13 at 04:32

score 0 · Answer 2 · answered Feb 04 '14 at 21:37

I had a similar issue and I solved it by using expects instead of should_receive. You might just need to update it to use expects like the following.


describe "PUT update" do
  describe "with valid params" do
    it "updates the requested invoice" do
      invoice = Invoice.create!
      Invoice.any_instance.expects(:update_attributes).with({"number" => "MyString"  })
      put :update, {:id => invoice.id, :invoice => { "number" => "MyString" }}
    end
  end
end

Kenrick Chien · Answer 3 · 2013-11-14T21:48:35.057

-1

Mocha, like many other mock frameworks, requires you to put your expectations before running the code under test.

Therefore, in your test, swap the two lines; i.e. call Invoice.create! after Invoice.any_instance.should_receive.

edited Nov 14 '13 at 21:48

answered Nov 14 '13 at 20:37

Kenrick Chien

1,036
8
22

The update attributes innovation is already occurring after the expeditions are set, in the line that follows. – Peter Alfvin Nov 14 '13 at 20:58

RSpec update_attributes expectation failing, even though update works

3 Answers3