how to resolve StackOverFlowError?

Question

My Inner and outer class file here:-

package com.demo;

public class Outer {
int outer_x=100;

void test(){
    Inner inner =new Inner();
    inner.display();
}
public class Inner {
void display(){
    Outer ob=new Outer();
    ob.test();

    System.out.println("display: outer_x= "+outer_x);
}
}

}

Another main class acess outer class member :-

package com.demo;

class InnerClassDemo{
    public static void main(String args[]){
        Outer outer=new Outer();
        outer.test();
    }
}

Exception:-

Exception in thread "main" java.lang.StackOverflowError
    at com.demo.Outer.<init>(Outer.java:3)
    at com.demo.Outer$Inner.display(Outer.java:12)
    at com.demo.Outer.test(Outer.java:8)

How can resolve this issue ,pls give me any idea?

which kind of error in test() method i acess the inner class method — , Nov 04 '13 at 16:50
Outer --> Inner --> Outer --> Inner --> Outer --> inner --> ........ StackOverFlowException — JNL, Nov 04 '13 at 16:52
@user2860053: Yes it is. What you are doing is recursively calling test and then display. see http://en.wikipedia.org/wiki/Recursion — MadConan, Nov 04 '13 at 17:05
@MadConan I dont know why you are talking its recurrsion but now i study example of nested and inner class including static and non_static nested class i know recurrion is a prosses of defining items itself. — , Nov 04 '13 at 17:15

score 2 · Accepted Answer · answered Nov 04 '13 at 16:50

Your test method creates an Inner and calls its display() method, which creates an Outer and calls its test method. Nothing in your code stops this from continuing forever, until enough methods have been called to fill up the stack space and a StackOverflowError occurs.

Either don't have test call display, or don't have display call test.

score 1 · Answer 2 · answered Nov 05 '13 at 15:17

1

I resolved this issue from @rgettman answer modified my Inner and outer class here

package com.demo;
public class Outer {
int outer_x=100;

void test(){
    Inner inner =new Inner();
    inner.display();
}
public class Inner {
void display(){

    System.out.println("display: outer_x= "+outer_x);
}
}

}

answered Nov 05 '13 at 15:17

1

FYI - This should go in an edit to your question, not an answer. – Scott Solmer Nov 05 '13 at 23:20
Thanks for giving new advice @Okuma.Scott – Nov 06 '13 at 05:20

score 0 · Answer 3 · answered Nov 04 '13 at 16:49

0

Outer.test calls Inner.display which calls Outer.test which calls Inner.display which calls Outer.test which calls Inner.display which...

This goes on until your program runs out of stack space.

answered Nov 04 '13 at 16:49

cangrejo

2,189
3
24
31

score 0 · Answer 4 · answered Nov 04 '13 at 16:52

0

You get StackOverFlowError, because your call has a infinite method call which always exceeds program stack.

Your test method calls display and display method calls testunconditionaly.

It is the basic requirement to define a base case for recursive methods, so you should define a base case which will return and stop recursive method calls.

See also

Recursion

answered Nov 04 '13 at 16:52

erencan

3,725
5
32
50

its not recurrsion @erencan – Nov 04 '13 at 17:10
you also create instances recursively and call only one time its methods. In the end, yes it is recursion. – erencan Nov 04 '13 at 17:14

how to resolve StackOverFlowError?

4 Answers4