Angularjs ng-show directive interprets the 'N' and 'NO' as falsy values

Question

It seems that Angularjs ng-show directive interprets the 'N' and 'NO' as falsy values.

In my angular application, I'm displaying data related to a specific country using the following <div ng-show="countryCode">some code</div> I was surprised when I figured out that data related to Norway are not shown. And this is because the country code of Norway is 'NO' which is considered as falsy value !!

I don't know if this is a design choice. but if Yes how you deal with this kind of issues

You can reproduce this here

Thank you in advance

Actually it's a design choice, you can see the responsible function here : https://github.com/angular/angular.js/blob/fca7bcaf43af3a4501ea0727d48f606c58d76bcd/src/Angular.js#L961 — DotDotDot, Oct 28 '13 at 13:43

JoeG · Accepted Answer · 2013-10-28T13:54:28.857

3

Use ng-show="!!countryCode" to force the behaviour you want.

From reading the code, the behaviour appears to be by design. However, the documentation says:

if the expression is truthy then the element is shown or hidden respectively

which is only true if the angular developers are using truthy to mean something different to its javascript meaning.

edited Oct 28 '13 at 13:54

answered Oct 28 '13 at 13:41

JoeG

12,994
1
38
63

1

bang, bang. I love JS. :) – Davin Tryon Oct 28 '13 at 13:50
1

Could use `ng-hide="!countryCode"` as well. – Davin Tryon Oct 28 '13 at 13:55
`!!` is an accepted idiom to get a boolean representing the truthiness of a javascript value. Good old dynamically typed languages. – JoeG Oct 28 '13 at 14:00
1

Yes, I think it's fine. If I came across code like that though I might not know why it was done that way. Might need a comment added for clarity. – Davin Tryon Oct 28 '13 at 14:03
@JoeGauterin nice trick from logic. indeed booleanValue=!(!booleanValue) Thank you – med Oct 28 '13 at 14:24

Angularjs ng-show directive interprets the 'N' and 'NO' as falsy values

1 Answers1