Crash when calling std::function from std::vector c++

Question

When I do this I get this error

Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call. This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention.

when calling dutyStack[0](); . But if I add dutyStack.reserve(10); or if I only have one element in the vector I do not get the error. I suspect something is going on when it's copying the elements when resizing the vector but I really have no idea.

#include "stdafx.h"
#include <iostream>
#include <vector>
#include <functional>

using namespace std;
class Class1
{
public:
    void duty1(){cout<<"duty1";}
    void duty2(){cout<<"duty2";}
};

int _tmain(int argc, _TCHAR* argv[])
{
    vector<tr1::function<void()>> dutyStack;
    Class1 myclass;

    dutyStack.push_back( tr1::bind(&Class1::duty1, myclass) );
    dutyStack.push_back( tr1::bind(&Class1::duty2, myclass) );

    dutyStack[0]();
    dutyStack.erase(dutyStack.begin());
}

I'm under visual studio 2008, Windows 7.

That code looks fine, except that I would have expected the `tr1` header to be ``. — juanchopanza, Oct 22 '13 at 20:12
As a sanity check, I modified the code slightly to compile under gcc 4.7.3 on Ubuntu 13.04 (argc/argv, std:: instead of tr1::, rm stdafx.h) and it also ran fine). If I invoke `dutyStack[0]();` after the `erase()`, it also outputs `duty2`, as expected. I suspect a bug in the older compiler/environment that you are using. — kfmfe04, Oct 24 '13 at 21:28
your code works fine with VS2010 + Win7 X64, compiled under 32bit. — ray_linn, Oct 25 '13 at 07:27
Code works fine in VS 2012. It is likely that there is a memory corruption in your code but not in the one you provided. — Raxvan, Oct 28 '13 at 10:44
What is the configuration for **Basic Runtime Checks** if you are in visual studio? — MahanGM, Oct 28 '13 at 12:32

score 4 · Answer 1 · answered Oct 29 '13 at 20:11

4

I have exactly the same environment as yours (Win7, VS 2008). I've just compiled and executed successfuly your code.

To me it looks like you have to recreate your project as you might have changes calling convension or similar stuff:

Configuration Properties > C/C++ > Advanced > Calling Conventions

..so recreating your project is simpliest check if this is your issue. If not this I bet you have some of your header files corrupted.

answered Oct 29 '13 at 20:11

Artur

7,038
2
25
39

1

I didn't test it but that is what I thought from reading the question. Nice clean response. Future reading for the question asker http://blogs.msdn.com/b/oldnewthing/archive/2004/01/08/48616.aspx – cbuteau Oct 31 '13 at 17:33
Works with VS2013 as well. The sample seems to be fine but the actual project not. – Alois Kraus Oct 31 '13 at 18:03
It seems to make sense, we had some changes in the project lately, I will see if I can do something with it soon. – DogDog Nov 04 '13 at 14:40

score 2 · Answer 2 · answered Oct 29 '13 at 13:05

Do you really need "stdafx.h" ? Aka, do you have pre-defined parameters for your project? Because the following works on vs2012, vs2010:

#include <iostream>
#include <vector>
#include <functional>

using namespace std;
class Class1
{
public:
    void duty1(){cout<<"duty1";}
    void duty2(){cout<<"duty2";}
};

int main()
{
    vector<tr1::function<void()>> dutyStack;
    Class1 myclass;

    dutyStack.push_back( tr1::bind(&Class1::duty1, myclass) );
    dutyStack.push_back( tr1::bind(&Class1::duty2, myclass));

    dutyStack[0]();
    dutyStack.erase(dutyStack.begin());

    system("pause");
    return 0;
}

Note that I removed "stdafx.h" and renamed "_tmain" as "main". Also removed args in main declaration as I didn't need them there.

I read something here that might have something common (_stdcall as _cecl call I would believe, but I am not far into C++ for this)

Crash when calling std::function from std::vector c++

2 Answers2