Can pthread_join() cause sequential execution?

Question

When I use the pthread_join(), I am not sure if it is in the right spot. As it is now, would it wait for the thread to exit before iterating through the loop again? I guess what I am asking is should I take it out of the double for loop and create a new for loop directly after just for the pthread_join()?

PS: I am very new to threads in general and the C language. I also have another question on freeing malloc stuff (in the code as comments). I am not sure where to use the free keyword since the malloc result pointer is gone after each iteration of the inside for loop.

Here is my code. It is for a matrix multiplication on two predefined matrices (A&B). (This is how the teacher wanted us to do it).

#include<stdio.h>
#include<stdlib.h>
#include<pthread.h>

#define M 3 
#define K 2  
#define N 3 

int A[M][K] = {{1,4}, {2,5}, {3,6}}; 
int B[K][N] =  {{8,7,6}, {5,4,3}}; 
int C[M][N]; 

struct coords 
{ 
    int  i ;  /*  row  */       
    int  j ;  /*  column  */ 
}; 

//thread function
void* calc_val(void* resultCoords)
{
    int n, result = 0;
    struct coords **matCoords = (struct coords**) resultCoords;
    for(n = 0; n < K; n++)
    {
        result += A[(*matCoords)->i][n] * B[n][(*matCoords)->j];
    }
    C[(*matCoords)->i][(*matCoords)->j] = result;
    // One more question: 
    // <- Should I free mem from malloc here? 
}

int main(int argc, char** argv) 
{
    int numThreads = M * N, threadIndex = 0, i, j;
    pthread_t threads[numThreads];
    pthread_attr_t attributes[numThreads];
    for (i = 0; i < M; i++)
    {
        for(j = 0; j < N; j++)
        {
            struct coords *data = (struct coords*)malloc(sizeof(struct coords));
            data->i = i;
            data->j = j;
            pthread_attr_init(&attributes[threadIndex]);
            pthread_create(
                    &threads[threadIndex],
                    &attributes[threadIndex],
                    calc_val, 
                    &data);
            pthread_join(threads[threadIndex], NULL); // <-Main Question
            threadIndex++;
        }
    }

    /* ... */

    return (EXIT_SUCCESS);
}

score 0 · Accepted Answer · answered Oct 12 '13 at 00:15

In your code you basically do following:

prepare some data for thread
run thread
wait till it finished
go to next iteration

so this code it absolutely sequential

to make it non sequential you need something like this:

prepare some data
run thread
go to next iteration
wait until all threads are finished

try something like this:

   for (i = 0; i < M; i++)
   {
        for(j = 0; j < N; j++)
        {
            struct coords *data = (struct coords*)malloc(sizeof(struct coords));
            data->i = i;
            data->j = j;
            pthread_attr_init(&attributes[threadIndex]);
            pthread_create(&threads[threadIndex], &attributes[threadIndex], calc_val, &data);
            threadIndex++;
        }
    }
    for (i=0;i<numThreads;i++)
        pthread_join(threads[i], NULL);

next problem about memory allocation - you can do it either when all threads are finished (then you need to store somewhere all allocated pointers), or you can just free in it each thread as you asked in comments

Wow, thanks for the quick response- your awesome! That is exactly the answer I was looking for. That helps me understand the pthread_join a lot better now. EDIT: For the freeing of malloc - I tried it in the thread function but got weird results, but your first suggestion worked like a charm. — willko747, Oct 12 '13 at 01:57
do you try free(resultCoords) or free(matCoords)? first one should work only — Iłya Bursov, Oct 12 '13 at 01:59

Can pthread_join() cause sequential execution?

1 Answers1