Ruby Ternary If Bug

Question

What I'm trying to do is print Pending Quotes if the count is 0 or >1 and Pending Quote if the count ==1 but if the count is >1, the output is 2 true, the other two cases work fine though and I can't see anything obvious.

<%= @pending.nil? ? '0' : @pending.count %>
<%= (!@pending.nil? and @pending.count > 1) or (!@pending.nil? and @pending.count == 0) ? 'Pending Quotes' : 'Pending Quote' %>

score 5 · Answer 1 · answered Oct 03 '13 at 08:18

5

I'd use the pluralize helper:

<%= pluralize(@pending, 'Pending Quote') %>

answered Oct 03 '13 at 08:18

Stefan

109,145
14
143
218

I don't know a bit of ROR.. so I sticked to Ruby only.. :) – Arup Rakshit Oct 03 '13 at 08:21

Arup Rakshit · Accepted Answer · 2013-10-03T08:26:00.040

1

You have to write this way :

((!@pending.nil? and @pending.count > 1) or (!@pending.nil? and @pending.count == 0)) ? 'Pending Quotes' : 'Pending Quote'

You could also write it as

(!@pending.nil? && (@pending.count > 1 || @pending.count == 0)) ? 'Pending Quotes' : 'Pending Quote'

edited Oct 03 '13 at 08:26

answered Oct 03 '13 at 08:12

Arup Rakshit

116,827
30
260
317

ah, feel silly now. Thanks, will mark it accepted when SO allows me :) – martincarlin87 Oct 03 '13 at 08:14
2

note: in Ruby is idiomatic to use `&&` `||` for boolean expresions. Use `and` `or` for flow control. Also, it may be worth noting to OP that "!x.nil?" is usually better as simply "x". – tokland Oct 03 '13 at 08:15
@tokland i agree with you – Arup Rakshit Oct 03 '13 at 08:17

spickermann · Answer 3 · 2013-10-03T09:33:52.363

1

With the help of De Morgan...

@pending.try(:count) == 1 ? 'Pending Quote' : 'Pending Quotes'

edited Oct 03 '13 at 09:33

answered Oct 03 '13 at 09:23

spickermann

100,941
9
101
131

thanks, that's a very neat way to put it – martincarlin87 Oct 03 '13 at 10:03

Ruby Ternary If Bug

3 Answers3