Non static method requires a target

Question

private PMS_USERS currUser;
private bool validateUserName()
{
    dbContext = new PmsEntities();
    var validateUser = dbContext.PMS_USERS.Where(p=> p.LOGICALREF != currUser.LOGICALREF).Where(p=> p.USERNAME == currUser.USERNAME);
    return !validateUser.Any();
}

Hello, I got an error while validating on my new user register form.

My PMS_USERS table has no record(null). I also tried checking for null control(s) for currUser.

What am I missing?

Error is :

Non static method requires a target

Seems a Try / Catch is needed here... – Hexie Sep 30 '13 at 12:56 — Hexie, Sep 30 '13 at 12:56

score 10 · Accepted Answer · answered Sep 30 '13 at 12:56

10

You should first test if currUser is null or not and your dbContext too.

if (currUser == null) return false;
if (dbContext == null) throw new Exception ("The dbContext has not been set");

Secondly, you can simplify your query like yhat :

 var validateUser = dbContext.PMS_USERS.Where(p=> p.LOGICALREF != currUser.LOGICALREF &&  p.USERNAME == currUser.USERNAME);

And then change the return statement to :

return (validateUser.FirstOrDefault() != null);

You can alternativelly use SingleOrDefault statement insead of FirstOrDefault, if you want to be sure there is only one user corresponding to your criteria.

answered Sep 30 '13 at 12:56

Rom Eh

1,981
1
16
33

Can you explain difference between `return validateUser.Any();` and `return (validateUser.FirstOrDefault() != null);`? Why you suggest 2nd instead of 1st? – Hamlet Hakobyan Oct 02 '13 at 09:36
In fact, I think it is the same thing. The Any is more simple. The problems came from the Where clause in this problem. – Rom Eh Oct 02 '13 at 09:49
Adding if (dbContext != null) check worked for me. Can you explain the reason? – Amey Khadatkar Apr 27 '16 at 19:33

score 2 · Answer 2 · edited Aug 20 '16 at 16:00

"Non static method requires a target" means that some object inside the scope is null.

Try checking the context and the var result values:

 dbContext = new PmsEntities();
 if (dbContext != null && currUser != null)
 {
     var validateUser = dbContext.PMS_USERS.Where(p=> p.LOGICALREF != currUser.LOGICALREF && p.USERNAME == currUser.USERNAME);

    if (validateUser !=null)
    {
       return !validateUser.Any();
    }
    else
       return null;
 }

Check it and tell us if you have the same exception.

score 1 · Answer 3 · answered Sep 30 '13 at 12:53

Use

private PMS_USERS currUser;
private bool validateUserName()
{
    dbContext = new PmsEntities();
    return PMS_USERS != null 
        ? var validateUser = dbContext.PMS_USERS.Where(p=> p.LOGICALREF != currUser.LOGICALREF).Where(p=> p.USERNAME == currUser.USERNAME).Any()
        : false;
}

Non static method requires a target

3 Answers3

Linked