how correctly to end all process of program

Question

my program has event onClosing - just hide it. But also i need to implement closing of programm - try to use context menu of task bar notification item.

code:

    private void FormMainForm_FormClosing(object sender, FormClosingEventArgs e)
    {
        //canceling closing form
        e.Cancel = true;
        //hide form 
        this.WindowState = FormWindowState.Minimized;
    }

    private void toolStripMenuItem1_Click(object sender, EventArgs e)
    {
        //hide icon from tray
        notifyIcon.Visible = false;
        //get current process
        Process proc = Process.GetCurrentProcess();
        //kill it and close programm
        proc.Kill();
    }

but also read a little bit, that kill() terminate all work and "kill" the process, think it can be not normal way to close programm - some data can be destroyed or not stored

also try to use proc.closeMainWindow(); and proc.Close() - but no effect on programm - all windows closed, but process still running.

Question: are .kill() it's a correct way to close programm, or ther is some another way to do it?

It is same if you kill it from Task manager. Is it correct way? — Hamlet Hakobyan, Sep 24 '13 at 15:56
Are you using foreground threads? If not use `Application.Exit()` — Sriram Sakthivel, Sep 24 '13 at 15:57
`Application.Exit()` - try it - only close all visible windows, but process still working — hbk, Sep 24 '13 at 16:01
Does your program create any background threads? If so you need to notify them that you are shutting down, so they can exit gracefully. — Surfbutler, Sep 24 '13 at 16:05
@Surfbutler realy never work with threads.. how to know how many thread have my programm - in code i dont create any additional thread — hbk, Sep 24 '13 at 16:09
If you don't explicitly create any, then don't worry. The answer posted by @nvoigt will do just fine. — Surfbutler, Sep 24 '13 at 17:16

score 5 · Accepted Answer · answered Sep 24 '13 at 15:58

You could just call .Close() in your menuitem click and set a boolean flag so that the OnClose handler can check that flag and know that it should really close. That would be a lot safer than trying to kill your own process.

private bool onlyHideOnClose = true;

private void FormMainForm_FormClosing(object sender, FormClosingEventArgs e)
{
    if(this.onlyHideOnClose)
    {
        e.Cancel = true;
        this.WindowState = FormWindowState.Minimized;
    }
}

private void toolStripMenuItem1_Click(object sender, EventArgs e)
{
    this.onlyHideOnClose = false;
    this.Close();
}

how correctly to end all process of program

1 Answers1