NSNotification - how to prevent unexpected crashes?

Question

In my app I have a few VCs that need to receive NSNotifications from my model, which is fetching data asynchronously. The problem is that the VCs disappear from time to time and when the model finishes fetching data and tries to send a notification to a VC that is already gone, the app crashes. Is there an option to prevent this crashing? Like telling NSNotificationCenter "it's ok if the observer is not there"?

:)

// Subscribe for notifications
[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(finishedLoading) name:@"Finished Loading" object:nil];

// Model sends a notification to a subscribed VC
[[NSNotificationCenter defaultCenter] postNotificationName:@"Finished Loading" object:nil userInfo:nil];

subhash kumar singh · Accepted Answer · 2013-09-23T14:56:34.610

2

Apple Documentation:

Be sure to invoke this method (removeObserver: or removeObserver:name:object:) before notificationObserver or any object specified in addObserver:selector:name:object: is deallocated.

add the removeObserver call to dealloc of observer.

- (void)dealloc{
...
[[NSNotificationCenter defaultCenter] removeObserver:self ];
...
}

edited Sep 23 '13 at 14:56

answered Sep 23 '13 at 14:47

subhash kumar singh

2,716
8
31
43

1

Of course you only call `[super dealloc]` if you are using MRC, not ARC. – rmaddy Sep 23 '13 at 14:49

score 1 · Answer 2 · answered Sep 23 '13 at 14:45

1

I think, you just need to do:

[[NSNotificationCenter defaultCenter] removeObserver:self ];

answered Sep 23 '13 at 14:45

Leo Chapiro

13,678
8
61
92

score 1 · Answer 3 · answered Sep 23 '13 at 14:45

1

You have to call NSNotificationCenter removeObserver... for each time you call addObserver.... This is typically done in the dealloc method.

answered Sep 23 '13 at 14:45

rmaddy

314,917
42
532
579

score 0 · Answer 4 · answered Sep 23 '13 at 14:50

0

To be honest, with this approach you are mitigating the symptoms rather than curing the disease.

If you are using an asynchronous networking library such as AFNetworking to return NSOperation instances, then you would be better to manage these in an NSOperationQueue. Then, when your controller is popped, in the viewWillDisappear method, cancel all outstanding asynchronous requests:

[myOpQueue cancelAllOperations];

answered Sep 23 '13 at 14:50

Max MacLeod

26,115
13
104
132

I like your approach, but I'm just using [NSData dataWithContentsOfURL:@""] to fetch data. – Nikolay Dyankov Sep 23 '13 at 14:56
so how are you scheduling that asynchronously? It must be with either NSOperation or gcd? – Max MacLeod Sep 23 '13 at 15:16

NSNotification - how to prevent unexpected crashes?

4 Answers4