What's wrong with this Decimal to Binary converter (without iteration)

Question

I'm trying to make a code for converting decimal into binary for n<16 without using iteration. but the output is always either 1000, 100, 10 or 1. what is wrong with the code? thank you very much

#include <stdio.h>

int main(void){
int decimal, bin = 0;
printf("Enter number to convert to base 2: ");
scanf("%d", &decimal);

if(decimal >= 8){
    bin += 1000;
    decimal = decimal%8;
}else if(decimal >= 4){
    bin += 100;
    decimal = decimal%4;
}else if(decimal >= 2){
    bin += 10;
    decimal = decimal%2;
}else if(decimal >= 0){
    bin += decimal%2;
}
printf("%5d", bin);
;
}

Remove all the `else` words from your code and it will start working. — jlahd, Sep 21 '13 at 14:44
jlahd's right, with "else"s it will only ever execute one of those bin+= statments — Joe T, Sep 21 '13 at 14:46

score 1 · Answer 1 · answered Sep 21 '13 at 14:45

1

Drop the else's. The tests must apply successively. If only one applies of course you get only a power of 2.

Of course, representing binary numbers as decimals is a really bad idea -- but for printing purposes only it would work.

answered Sep 21 '13 at 14:45

dan3

2,528
22
20

I got it. Oh yeah I just need to print it for now, so decimal will do. Thank you very much. – Imran Ariffin Sep 22 '13 at 01:35

What's wrong with this Decimal to Binary converter (without iteration)

1 Answers1