7

I have about 1.5 million files I need to insert records for in the database. Each record is inserted with a key that includes the name of the file.

The catch: The files are not uniquely identified currently.

So, what we'd like to do is, for each file:

  • Insert a record. One of the fields in the record should include an amazon S3 key which should include the ID of the newly inserted record.
  • Rename the file to include the ID so that it matches the format of the key.

The best thing I can think to do is:

  • Run an individual insert command that returns the ID of the added row.
  • Add that back as a property to the individual business object I'm looping through.
  • Generate an update statement that updates the S3 key to include the ID
  • Output the file, concatenate the ID into the end the file name.

As I can tell, that looks to be :

  • 1.5 million insert statements
    • individual SqlCommand executions and read because we need the ID back),
  • 1.5 million times setting a property on an object.
  • 1.5 million update statements generated and executed
    • Perhaps could make this a one giant concatenated update statement to do them all at once; not sure if that helps
  • 1.5 million file copies.

I can't get around the actual file part, but for the rest, is there a better strategy I'm not seeing?

SeanKilleen
  • 8,809
  • 17
  • 80
  • 133
  • maybe you can use a computed column (http://technet.microsoft.com/en-us/library/ms191250%28v=SQL.105%29.aspx) that's persisted to the db – Jason Sep 18 '13 at 15:51
  • Or set ID column identity starts from 2 000 000, then enable `IDENTITY_INSERT`, in c# code builde insert query with all columns with ID(for example 1 to 1 500 000) After disable `IDENTITY_INSERT` – Fabio Sep 18 '13 at 15:58
  • In the C#, can you tag a column to the insert record with a `Guid()`? so the DB will have a unique ID and so will the files name. – Christian Phillips Sep 18 '13 at 16:01

2 Answers2

3

If you make the client application generate the IDs you can use a straight-forward SqlBulkCopy to insert all rows at once. It will be done in seconds.

If you want to keep the IDENTITY property of the column, you can run a DBCC CHECKIDENT(RESEED) to advance the identity counter by 1.5m to give you a guaranteed gap that you can insert into. If the number of rows is not statically known you can perform the inserting in smaller chunks of maybe 100k until you are done.

usr
  • 168,620
  • 35
  • 240
  • 369
1

You will cut the number of SQL statements in half up by not relying on the database to generate your ID for each row. Do everything locally (including the assignment of an ID) and then do a single batch of inserts at the end, with identity_insert on.

This will cause SQL Server to use your ID's for this batch of records.

If this is still too slow (and 1.5 million inserts might be), the next step would be to output your data to a text file (XML, comma delimited, or whatever) and then do a bulk import operation on the file.

That's as fast as you will be able to make it, I think.

Roger Rouse
  • 2,287
  • 2
  • 15
  • 10