when pressed wil ++ or -- a value, numeric keypad

Question

Using numeric keypad I have added a .switch handler which when clicked will bring the value back to '0' (test purpose only)

If the value is +32 and the button is pressed I would like it to change to -32, vice versa.

so far I have only gotten it to return to 0, i was thinking then deleting or adding the val again, even tried -- $('#myInput').val());

$('.switch').click(function () {
    if (!isNaN($('#myInput').val()) && $('#myInput').val().length > 0) {
        $('#myInput').val(parseInt($('#myInput').val()) - $('#myInput').val());
    }
    if (!isNaN($('#myInput').val()) && $('#myInput').val().length < 0) {
        $('#myInput').val(parseInt($('#myInput').val()) + $('#myInput').val());
    }
});

score 3 · Accepted Answer · answered Sep 18 '13 at 12:14

3

If all you're trying to do is switch back and forth between a positive/negative number you can make your code much simpler and lose all the if conditions:

$('.switch').click(function () {
    var $input = $('#myInput');
    $input.val() != "" && !isNaN($input.val()) && $input.val(-$input.val());
});

This is the equivalent of multiplying the number by -1, which will have the same effect.

Example fiddle

answered Sep 18 '13 at 12:14

Rory McCrossan

331,213
40
305
339

+1, but consider the target audience when replacing an `if` with `&&` with no explanation. – nnnnnn Sep 18 '13 at 12:19

score 2 · Answer 2 · answered Sep 18 '13 at 12:11

$('#myInput').val().length < 0 when will a length of a string be less than zero?

parseInt($('#myInput').val()) + $('#myInput').val() this doesn't actually do numeric addition, if th value is the string 1 then it will be like doing 1+"1" which will return 11

I think what you're looking for is :

$('.switch').click(function () {
            var val = parseInt($('#myInput').val());
            $('#myInput').val(-val);
    });

see here

when pressed wil ++ or -- a value, numeric keypad

2 Answers2