Mean and Standard Deviation wrong c#

Question

I've been doing an app since few days ago but it's wrong and I do not know why.

I've done the same operation in various ways. I've searched here on the blog, but I still get the incorrect result.

I hope you can help me:

I'm calculating the ** Mean and Standard Deviation**. The Mean is OK. The Standard Deviation is wrong. This is my code:

    LinkedList<Double> lista = new LinkedList<Double>();
    int contador = 0;

    private void btnAgregar_Click(object sender, EventArgs e)
    {
        lista.AddLast(Convert.ToDouble(txtNum.Text));
        MessageBox.Show("Se agregó el número: " + txtNum.Text);
        contador++;
        txtNum.Text = "";
        txtNum.Focus();
    }

    Double media;
    Double desviacionE = 0;
    Double suma = 0;

    private void btnCalcular_Click(object sender, EventArgs e)
    {
        media = 0;
        calculaMedia();
        calculaDesviacionE();
    }

    public void calculaMedia()
    {
        foreach (var item in lista)
        {
            String valorItem = item.ToString();
            suma = suma + Convert.ToDouble(valorItem);
        }
        media = suma / contador;
        txtMedia.Text = "" + media;
    }

    public void calculaDesviacionE()
    {
        Double average = lista.Average();
        Double sum = 0;
        foreach (var item in lista)
        {
            sum += ((Convert.ToDouble(item.ToString()))*(Convert.ToDouble(item.ToString())));
        }
        Double sumProm = sum / lista.Count();
        Double desvE = Math.Sqrt(sumProm-(average*average));
        txtDesv.Text = "" + desvE;
    }

I hope You can help me! Thank You

AnotherDeveloperNamedGreg · Answer 1 · 2013-09-17T22:00:42.580

1

You need to subtract the average before squaring.

// Population Standard Deviation
public void populationStandardDev()
{
    Double average = lista.Average();
    Double sum = 0;
    foreach (var item in lista)
    {
        Double difference = item - average;
        sum += difference*difference;
    }
    Double sumProd = sum / lista.Count(); // divide by n
    Double desvE = Math.Sqrt(sumProd);
}

// Standard deviation
public void standardDev()
{
    Double average = lista.Average();
    Double sum = 0;
    foreach (var item in lista)
    {
        Double difference = item - average;
        sum += difference*difference;
    }
    Double sumProd = sum / (lista.Count()-1); // divide by n-1 
    Double desvE = Math.Sqrt(sumProd);
}

edited Sep 17 '13 at 22:00

answered Sep 17 '13 at 21:31

AnotherDeveloperNamedGreg

577
1
8
12

Thank your @Greg ... The problem is, according to your code and my data: >>160 >>591 >>114 >>229 >>230 >>270 >>128 >>1657 >>624 >>1503 the standard deviation is **542.672313647932** But it should show: **572.03** I don't know what is wrong! :/ – Jean Sep 17 '13 at 21:39
Sorry I just noticed your list is already made up of Doubles so you don't need to convert them to Strings and then convert them to Doubles again. – AnotherDeveloperNamedGreg Sep 17 '13 at 21:42
Sorry I gave you formula for population standard deviation at first. – AnotherDeveloperNamedGreg Sep 17 '13 at 22:02
I did it! I have the right result: **Thank You so much!** – Jean Sep 17 '13 at 22:18

score 1 · Accepted Answer · answered Sep 17 '13 at 22:20

Following the rules for standard deviation found at http://en.wikipedia.org/wiki/Standard_deviation

        LinkedList<Double> list = new LinkedList<Double>();
        double sumOfSquares = 0;
        double deviation;
        double delta;
        list.AddLast(2);
        list.AddLast(4);
        list.AddLast(4);
        list.AddLast(4);
        list.AddLast(5);
        list.AddLast(5);
        list.AddLast(7);
        list.AddLast(9);


        double average = list.Average();
        Console.WriteLine("Average: " + average);

        foreach (double item in list)
        {
            delta = Math.Abs(item - average);
            sumOfSquares += (delta * delta);
        }
        Console.WriteLine("Sum of Squares: " + sumOfSquares);

        deviation = Math.Sqrt(sumOfSquares / list.Count());
        Console.WriteLine("Standard Deviation: " + deviation); //Final result is 2.0

Walter Alva · Answer 3 · 2013-09-17T23:05:48.753

The formula depends on the set of data you have.

Is it the entire population? Then you should use the Population Standard Deviation (divisor: n).
Is the data a sample of a set? Then you should use the Sample Standard Deviation (divisor: n - 1)

You may find an easier-to-understand guide here: Laerd Statistics - Standard Deviation, which also has a handy Calculator for both solutions.

So, it is as @Greg answered, though I would first check if the list holds any values to avoid division by zero.

double stdDeviation = 0;
if (lista.Any())
{
    var avg = lista.Average();
    var sumOfSquares = lista.Sum(item => Math.Pow(item - avg, 2));

    stdDeviation = Math.Sqrt(sumOfSquares / [divisor goes here]);
}
return stdDeviation;

Where the divisor be lista.Count() for population or (lista.Count() - 1) for samples.

Mean and Standard Deviation wrong c#

3 Answers3