VB.NET MsgBox Yes only works the second time?

Question

So this is my code below. When I click the X button on the form, the message box shows and clicking no works but when I click yes, the message box closes and comes up again quickly and then the second time, clicking either button will close the form. What's wrong with it?

    Private Sub Config_FormClosing(ByVal sender As System.Object, ByVal e As System.Windows.Forms.FormClosingEventArgs) Handles MyBase.FormClosing
    Dim result = MessageBox.Show("Would you like to quit?", MessageBoxButtons.YesNo)
    If result = DialogResult.No Then
        e.Cancel = True
    ElseIf result = DialogResult.Yes Then
        Application.Exit()
    End If
End Sub

Thanks in advance

score 6 · Accepted Answer · answered Sep 17 '13 at 04:06

6

Application.Exit will cause your form to be closed (recursively) so you see the message box again. In the event the user presses Yes in the message box, you should just do nothing in your event handler and allow the application exit to continue.

By not setting e.Cancel = True you would indicate that you want the form shutdown to continue.

answered Sep 17 '13 at 04:06

Ameen

2,576
1
14
17

Thanks! It was that simple. – zxzxzx Sep 17 '13 at 04:08

senthilkumar2185 · Answer 2 · 2013-09-17T15:03:19.567

1

This code Work Properly

 Private Sub Form1_FormClosing(ByVal sender As Object, ByVal e As System.Windows.Forms.FormClosingEventArgs) Handles Me.FormClosing
            If (MsgBox("Are you sure to Close", MsgBoxStyle.YesNo, "Close Event") = MsgBoxResult.Yes) Then
                e.Cancel = False
            Else
                e.Cancel = True
            End If
End Sub

edited Sep 17 '13 at 15:03

answered Sep 17 '13 at 04:18

senthilkumar2185

2,536
3
22
36

If the form was shown using the Show method, then calling Dispose is not necessary. The form will be automatically disposed. – Chris Dunaway Sep 17 '13 at 14:38

VB.NET MsgBox Yes only works the second time?

2 Answers2