Button.setClickable(false) is not working

Question

I have set mButton.setClickable(false); in my code but still this button is invoked by global button.setOnClickListener of my code.

EDIT: sorry for the delayed update. Below is the details view where I face the issue.
inside my listview customAdapter class getView method

@Override
public View getView(int position, View convertView, ViewGroup parent)
{
    View row = convertView;
    YourWrapper wrapper = null;
    HashMap<String, Object> cTa= new HashMap<String, Object>();
    cTa= d.getPosition(position)
    Button mButton = (Button)convertView.findViewById(R.id.mBtn);
    if (row == null)
    {
        row = inflater.inflate(R.layout.layout, parent, false);
        wrapper = new YourWrapper (row);
        row.setTag(wrapper);
    }
    else
        wrapper = (YourWrapper) row.getTag();

     if(success)
        {
                    // section-1
            mButton.setClickable(true);
        }
        else{
                   // section-2
            mButton.setClickable(false);
            mButton.setFocusable(false);
        }
    wrapper.getButton().setOnClickListener(new OnClickListener()
    {
        @Override
        public void onClick(View v)
        {
            //operation
        }
    });

    return row;
}

Above is the current code which working,and on section-2 it makes the mButton clickable- false, and focusable - false but still it's listen the below wrapper.getButton().setOnClickListener() and perform the operation. Please suggest me. Sorry for delayed update. Thanks!

UPDATE: I have made below hot-fixes that solve the problem for now.

// section-2
mButton.setVisibility(View.GONE);
mButton.setClickable(false);
mButton.setFocusable(false);

Is this your whole code? Is `mButton` the same as `wrapper.getButton()`? If so, why don't you put the part with `setOnClickListener` in your section-1? — Jan, Sep 16 '13 at 18:06

Jan · Answer 1 · 2014-12-12T16:49:16.267

57

That seems to be by design. This is from the documentation of the View.setOnClickListener method:

Register a callback to be invoked when this view is clicked. If this view is not clickable, it becomes clickable.

edited Dec 12 '14 at 16:49

answered Sep 16 '13 at 10:33

Jan

1,394
10
12

19

srsly..."If this view is not clickable, it becomes clickable." is a huge design flaw in my opinion. Thanks for the answer, this should be accepted. – JacksOnF1re Dec 12 '14 at 16:42
1

I agree with @JacksOnF1re. Android is a seriously rushed job with some of the dumbest design decisions. The same with button `setAlpha(0);` - the button is still clickable even when alpha is 0. Who in their sane mind would make a button invisible and still let it be clickable, under what circumstance would one want that in their app? Some silly guessing game with invisible buttons? Guess where I am! *rolls eyes* – Zhang Jun 23 '17 at 04:52

joecizac · Answer 2 · 2014-03-10T10:50:46.953

50

Instead of using setClickable(false) use setEnabled(false)

edited Mar 10 '14 at 10:50

answered Nov 21 '13 at 05:40

joecizac

1,077
2
13
14

@ADT I have edited the answer. Do try and let me know the outcome :) – joecizac Mar 10 '14 at 10:52
1

@jozze using both setClickable and setEnabled worked for me – Adrian Adamczyk Jul 28 '15 at 05:58
using `setEnable(false)` if there is background for view , it disappears – MMK Nov 29 '18 at 13:07

score 11 · Answer 3 · answered Sep 27 '19 at 01:22

11

Put setClickable after setOnClickListener

mBtn.setOnClickListener(this);
mBtn.setClickable(false);

if you put setClickable(false) before setOnClickListener(this), it doesn't work.

answered Sep 27 '19 at 01:22

Aaron

139
1
3

This looks pretty good answer, but I wonder why it is not still upvoted – Jeyaseelan Jan 30 '20 at 05:22
@Jeyaseelan because the same answer was already given 6 years before this answer. https://stackoverflow.com/a/18825890/1080954 – osayilgan Jun 25 '21 at 05:39

score 4 · Answer 4 · answered Sep 16 '13 at 10:39

4

Instead of using setClickable(false) use following

button.setFocusableInTouchMode(false);

I had the same problem in my app where i needed to set my button not to clickable in certain conditions. this worked for me. Hope this helps.

answered Sep 16 '13 at 10:39

mananjani

185
5

score 3 · Answer 5 · edited Jan 08 '18 at 09:48

3

Use View.setOnClickListener() before View.setClickable() ,or the method setOnclickLisnter() will set the flag true.

edited Jan 08 '18 at 09:48

Sarabjit Singh

1,814
1
17
28

answered Jan 08 '18 at 08:40

evans fueng

31
1

score 1 · Answer 6 · answered Oct 11 '19 at 17:53

1

I'm not sure if you're still looking for the answer, but for some weird reason

mBtn.setClickable(true);

stops the view from getting clicked and

mBtn.setClickable(false);

makes it clickable again.

answered Oct 11 '19 at 17:53

Saad Waseem

13
2
4

score 1 · Answer 7 · answered Jul 01 '21 at 13:19

1

on xml

android:enabled="false"

android:alpha="0.5"

dynamically

yourButtonId.alpha = 0.5f

yourButtonId.isEnabled = false

answered Jul 01 '21 at 13:19

Emine Sa

31
3

Yes, it will work – Anand Jan 02 '23 at 06:19

score 0 · Answer 8 · answered Aug 02 '17 at 08:48

0

You can check like if(!view.isClickable()) return;

answered Aug 02 '17 at 08:48

Qamar

4,959
1
30
49

score 0 · Answer 9 · answered Aug 13 '17 at 18:00

This will work in case of Imageview as well as the button.

 private OnClickListener onClickListener = new OnClickListener() {
        @Override
        public void onClick(View v) {
        if (imageview.isEnabled()){
            //I have wrapped all code inside onClick() in this if condition
            //Your onClick() code will only execute if the imageview is enabled
            //Now we can use setEnabled() instead of setClickable() everywhere
        }}
    };

Inside onCreate(), you can do setEnabled(false) which will be equivalent to setClickable(false).

We are able to use setEnabled() as tag because it's state remains uneffected on invocation of click (unlike setClickable() whose state changes).

score 0 · Answer 10 · answered Nov 12 '19 at 14:11

Like Other friends said, setOnClickListener will override the flag to true.
So the Workaround is to setOnTouchEvent return true whenever you want to disable clicks and set it to retrun false when you want to enable click events.
This is because onTouchEvent is called before every clickListener you define for a view, so returning true will say to all listeners that :

"Ok, I received this event here, nobody else can receive it".

So your solution may be something like this:

@Override
public View getView(int position, View convertView, ViewGroup parent)
{
    View row = convertView;
    YourWrapper wrapper = null;
    HashMap<String, Object> cTa= new HashMap<String, Object>();
    cTa= d.getPosition(position)
    Button mButton = (Button)convertView.findViewById(R.id.mBtn);
    if (row == null)
    {
        row = inflater.inflate(R.layout.layout, parent, false);
        wrapper = new YourWrapper (row);
        row.setTag(wrapper);
    }
    else
        wrapper = (YourWrapper) row.getTag();

     if(success)
        {
                    // section-1
            mButton.setOnTouchListener((v, event) -> false);
        }
        else{
                   // section-2
            mButton.setOnTouchListener((v, event) -> true);
        }
    wrapper.getButton().setOnClickListener(new OnClickListener()
    {
        @Override
        public void onClick(View v)
        {
            //operation
        }
    });
    return row;
}

score 0 · Answer 11 · answered Jul 22 '20 at 19:53

Set the click listener to null

someView.setOnClickListener(null)

As @Jan notes, the setOnClickListener enables the click listener automatically. Therefore, a null click listener can be set to disable future clicks. After setting the view to a null click listener, there are no adverse effects to future clicks on that view.

score 0 · Answer 12 · answered Dec 19 '20 at 19:24

0

I wanted to do it on Spinner, and only this one worked for me:

spinner.setOnTouchListener { v, event ->
                return@setOnTouchListener true
            }

answered Dec 19 '20 at 19:24

M. Usman Khan

3,689
1
59
69

score 0 · Answer 13 · answered Jan 30 '21 at 10:22

0

I just checked setClickable(true) and setClickable(false) on Android 4.1.1 and it seems to be working now.

answered Jan 30 '21 at 10:22

Rocky666

91
1
5

Button.setClickable(false) is not working

13 Answers13

Set the click listener to null

Linked