Am I using "data" correctly in my function

Question

I'm new to jQuery and I was wondering if I am passing my JSON data correctly into the function.

If I am saying something incorrectly or there is more information I need to provide. Please feel free to let me know! Thank you for all the help! Much appreciated!

According to Chrome Developer Tools. I get this error:

    Uncaught TypeError: Cannot read property 'GhStatus' of undefined

Here is my function:

        function MachineOffChecker() {
                var url = '@Html.Raw(Url.Action("index","GhCs"))';
                $.get(url, window.setInterval(
                                function(data) {                                                        
                                    if (data.GhStatus == 0) {                                                  
                                        $('#GhCsStatus_CS').buttonMarkup({ icon: 'myapp-cs' });     
                                       alert('crash');
                                    }
                                    else {
                                        $('#GhCsStatus_GH').buttonMarkup({ icon: 'myapp-gh' });      
                                        alert('running');
                                    }
                                    if (data.CsStatus == 0) {                                                 
                                        $('#GhCsStatus_CS').buttonMarkup({ icon: 'myapp-cs' });     
                                        alert('crash');
                                    }
                                    else {
                                        $('#GhCsStatus_GH').buttonMarkup({ icon: 'myapp-gh' });     
                                        alert('running');
                                    }
                                }, 2000), "json");                                                  
            }

This is my JSON data:

    {
        "GhStatus": 0,
        "CsStatus": 0
    }

window.setInterval where you used it doesn't make sense. $.get expects a function, an object, an array, or a string as it's 2nd argument. you gave it an integer. — Kevin B, Sep 12 '13 at 17:24
@tymeJV - no it does not! It would call the ajax method, but not as intended. — adeneo, Sep 12 '13 at 17:24
@adeneo -- Just making sure...never seen the `window.setInterval` used where it is. — tymeJV, Sep 12 '13 at 17:25
The setInterval is a function, so it would work, but it would keep calling that function over and over, which makes no sense, — adeneo, Sep 12 '13 at 17:26
@adeneo the specific function im doing uses setInterval so I need it haha — Liondancer, Sep 12 '13 at 17:34
@KevinB my second argument is a function. My first argument in .get() is a string (url) — Liondancer, Sep 12 '13 at 17:41
Your second argument is the integer that is returned by `window.setInterval()`. Try it yourself. `alert(window.setInterval(function(){},1000));` it's an integer, not a function. — Kevin B, Sep 12 '13 at 17:42

Vlad · Answer 1 · 2013-09-12T17:29:46.867

1

You should set your dataType to json. Or you can use $.getJSON().

Edit:

You need the quotes "json"

edited Sep 12 '13 at 17:29

answered Sep 12 '13 at 17:24

Vlad

978
6
13

1

he did at least try to do that, `JSON` should have been `"JSON"` – Kevin B Sep 12 '13 at 17:24
1

Should be "json", no? – Vlad Sep 12 '13 at 17:28
1

either or should work, it gets put to lowercase by jQuery. https://github.com/jquery/jquery/blob/1.9-stable/src/ajax.js#L69 – Kevin B Sep 12 '13 at 17:29

score 1 · Accepted Answer · answered Sep 12 '13 at 17:27

1

Have you tried this?

 window.setInterval(
     $.get(url,function(data) {                                                        
        if (data.GhStatus == 0) {                                                  
           $('#GhCsStatus_CS').buttonMarkup({ icon: 'myapp-cs' });     
           alert('crash');
        }else{
           $('#GhCsStatus_GH').buttonMarkup({ icon: 'myapp-gh' });      
           alert('running');
        }

        if (data.CsStatus == 0) {                                                 
           $('#GhCsStatus_CS').buttonMarkup({ icon: 'myapp-cs' });     
           alert('crash');
        }else{
           $('#GhCsStatus_GH').buttonMarkup({ icon: 'myapp-gh' });     
           alert('running');
        }
     }, "json")
 ,2000);

answered Sep 12 '13 at 17:27

DonaldAnderson

168
5

Thank you for this suggestion! I'm switching over to this format! – Liondancer Sep 12 '13 at 18:16
I have a question. If both my values are 0, crash pop up should appear every 2 seconds correct? – Liondancer Sep 12 '13 at 18:21
1

if both values are 0. then every two seconds crash will pop up twice. – DonaldAnderson Sep 12 '13 at 18:29
hmmm crash pops up twice but only one iteration occurs. I thought it would occur every 2 seconds =/ i'll have to look and try again – Liondancer Sep 12 '13 at 18:31
wrap the `$.get` stuff in a function then give that function to `setInterval`. Call setInterval with `$(document).ready` See example: http://stackoverflow.com/a/5140963/2456100 – DonaldAnderson Sep 12 '13 at 18:45
This is my code. http://pastebin.com/X2PXDT9Z The function runs only once and then i get errors =[ – Liondancer Sep 12 '13 at 20:46
Well the function() runs once well but after that I get errors at the set intervaL – Liondancer Sep 12 '13 at 20:47

Am I using "data" correctly in my function

2 Answers2